use DiffTreeSummary instead of deprecated DiffSummary query #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogenstad
reviewed
Oct 7, 2024
| from typing_extensions import NotRequired, TypedDict | ||
|
|
||
|
|
||
| class NodeDiff(TypedDict): |
There was a problem hiding this comment.
FYI we have a:
from infrahub_sdk.client import NodeDiff # noqa: TCH002In infrahub/message_bus/types.py, it would still work since we are importing NodeDiff into infrahub_sdk/client but it gets a bit weird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IFC-727
infrahub PR opsmill/infrahub#4546
use the new DiffTreeSummary query instead of the deprecated DiffSummary graphql query in
get_diff_summary