-
Notifications
You must be signed in to change notification settings - Fork 6
Prevent InfrahubNode from instantiating optional relationships of car… #631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…dinality one with None data.
WalkthroughThis change addresses how optional one-to-one relationships are handled when generating mutation input data. Previously, uninitialized optional relationships were explicitly set to Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying infrahub-sdk-python with
|
| Latest commit: |
4eb8bcb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://293bc896.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://atg-20251113-ihs-179.infrahub-sdk-python.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests.
@@ Coverage Diff @@
## stable #631 +/- ##
==========================================
- Coverage 75.48% 69.84% -5.64%
==========================================
Files 113 113
Lines 9512 9511 -1
Branches 1893 1893
==========================================
- Hits 7180 6643 -537
- Misses 1832 2365 +533
- Partials 500 503 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 25 files with indirect coverage changes 🚀 New features to boost your workflow:
|
ogenstad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to consider this a bit more, it looks like we're reverting the things done in #515 with this PR. So we need to take a closer look at that's going on here.
|
Closing for now as I have a work around. |
…dinality one with None data.
Fixes: #630
Summary by CodeRabbit