Skip to content

Conversation

@ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Nov 14, 2025

In previous versions of infrahub-testcontainer we had some issues that prevented it from being used with earlier versions of Python. This PR bumps the package to the latest version and removes the Python version constraint.

Summary by CodeRabbit

  • Chores
    • Updated test dependencies to newer versions for improved testing infrastructure.

@coderabbitai
Copy link

coderabbitai bot commented Nov 14, 2025

Walkthrough

The test dependencies were updated in the project configuration. The infrahub-testcontainers package dependency was changed from a version-conditional requirement (minimum version 1.5.0 for Python 3.12+) to an unconditional requirement with a higher minimum version (1.5.1). This removes the Python version constraint while requiring a newer version of the package for all test environments.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Update infrahub-testcontainers' directly matches the main change in the PR, which updates the infrahub-testcontainers dependency and removes version constraints.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pog-testcontainers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff            @@
##           develop     #633   +/-   ##
========================================
  Coverage    75.56%   75.56%           
========================================
  Files          113      113           
  Lines         9512     9512           
  Branches      1448     1448           
========================================
  Hits          7188     7188           
  Misses        1837     1837           
  Partials       487      487           
Flag Coverage Δ
integration-tests 34.95% <ø> (ø)
python-3.10 48.85% <ø> (-0.03%) ⬇️
python-3.11 48.87% <ø> (ø)
python-3.12 48.85% <ø> (ø)
python-3.13 48.83% <ø> (-0.03%) ⬇️
python-3.9 47.55% <ø> (ø)
python-filler-3.12 24.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ogenstad ogenstad marked this pull request as ready for review November 14, 2025 07:09
@ogenstad ogenstad requested a review from a team November 14, 2025 07:09
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c0eb8a1 and a05a1a6.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Cloudflare Pages

[dependency-groups]
# Core optional dependencies
tests = [
"infrahub-testcontainers>=1.5.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify infrahub-testcontainers>=1.5.1 is compatible with Python 3.9 and 3.10.

The change removes the Python version constraint, making this dependency apply to all supported versions (Python 3.9+). Verify that infrahub-testcontainers>=1.5.1 is available on PyPI and confirmed to work with Python 3.9 and 3.10, especially given the PR note that earlier versions had compatibility issues.


🌐 Web query:

What is the latest version of infrahub-testcontainers and its Python version requirements?

💡 Result:

Latest version: 1.4.12 (released Oct 23, 2025). Python requirement: Requires Python >= 3.9 (classifiers list support for Python 3.9–3.13). [1]

Sources: [1] PyPI — infrahub-testcontainers project page (release 1.4.12).


Specify a valid version number for infrahub-testcontainers. Version 1.5.1 does not exist on PyPI.

The latest available version is 1.4.12 (released Oct 23, 2025), which already supports Python >= 3.9–3.13. The specified version 1.5.1 will cause installation failures. Either use the latest available version (1.4.12) or verify the intended version number if a newer release is expected.

🤖 Prompt for AI Agents
In pyproject.toml around line 75, the dependency pin
"infrahub-testcontainers>=1.5.1" references a non-existent PyPI release and will
break installs; change it to a valid release (for example use
"infrahub-testcontainers==1.4.12" or a compatible range like
"infrahub-testcontainers>=1.4.12,<1.5" if you want updates within the current
major line), or confirm and replace with the intended future version if a newer
release is expected.

@ogenstad ogenstad merged commit dc79402 into develop Nov 14, 2025
20 checks passed
@ogenstad ogenstad deleted the pog-testcontainers branch November 14, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants