Skip to content

Fix Yoda condition (SIM300) #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Fix Yoda condition (SIM300) #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,6 @@ ignore = [
"SIM114", # Combine `if` branches using logical `or` operator
"SIM117", # Use a single `with` statement with multiple contexts instead of nested `with` statements
"SIM118", # Use `key in dict` instead of `key in dict.keys)
"SIM300", # Yoda condition detected
"SIM910", # Use `data.get(key)` instead of `data.get(key, None)`
"UP007", # Use X | Y for type annotations
"UP031", # Use format specifiers instead of percent format
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/sdk/test_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ async def test_schema_data_validation(rfile_schema, client_type):
schema=rfile_schema, data={"name": "some-name", "invalid_field": "yes"}
)

assert "invalid_field is not a valid value for CoreTransformJinja2" == excinfo.value.message
assert excinfo.value.message == "invalid_field is not a valid value for CoreTransformJinja2"


@pytest.mark.parametrize("client_type", client_types)
Expand Down