Cont working on the new menu in the backend #4623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
group/backend
CodSpeed Performance ReportMerging #4623 will degrade performances by 99.81%Comparing Summary
Benchmarks breakdown
|
bilalabbad
reviewed
Oct 14, 2024
ogenstad
approved these changes
Oct 14, 2024
| order_weight=obj.order_weight.value, | ||
| path=obj.path.value or "", | ||
| kind=obj.get_kind(), | ||
| kind=obj.kind.value or "", |
There was a problem hiding this comment.
Based on the MenuItem class and the obj.kind.value or "" it seems like kind, path and icon should perhaps be mandatory as strings but have "" as the default value. Having said that I don't know if this would work in the frontend (.i.e. to send in a required blank value).
dgarros
force-pushed
the
dga-20241011-menu
branch
from
3b20326 to
2e7619d
Compare
dgarros
force-pushed
the
dga-20241011-menu
branch
from
2e7619d to
d511944
Compare
bilalabbad
reviewed
Oct 15, 2024
| - namespace: Organization | ||
| name: Manufacturer | ||
| label: Manufacturer | ||
| kind: LocationManufacturer |
There was a problem hiding this comment.
Schema does seem to exist in demo data right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev.load-infra-schemato load both the schema and the menuThe changes in the Python SDK are being tracked in this PR opsmill/infrahub-sdk-python#73