Skip to content

Add support for convert_query_response to Python Transforms #6363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

Add support for convert_query_response to Python Transforms #6363

merged 1 commit into from
Apr 30, 2025

Conversation

@ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Apr 25, 2025 •
edited
Loading

Changes:

  • Add convert_query_response parameter in a lot of places
  • Adds convert_query_response as an attribute to the Python transform in the schema
  • Hardcoded convert_query_response to False in a few places. This is mainly to be able to manage Jinja2 Transforms with the same code
  • Add and update tests

Requires opsmill/infrahub-sdk-python#376 from the SDK

@github-actions github-actions bot added type/documentation Improvements or additions to documentation group/backend Issue related to the backend (API Server, Git Agent) labels Apr 25, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 25, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #6363 will not alter performance

Comparing pog-query-convert-response-IFC-1479 (c3d2199) with stable (c5d0949)

Summary

✅ 10 untouched benchmarks

@ogenstad ogenstad force-pushed the pog-query-convert-response-IFC-1479 branch 5 times, most recently from 2dddc9c to e2a588c Compare April 28, 2025 13:11
@ogenstad ogenstad mentioned this pull request Apr 28, 2025
Merged
@ogenstad ogenstad marked this pull request as ready for review April 28, 2025 13:28
@ogenstad ogenstad requested review from a team as code owners April 28, 2025 13:28
@ogenstad ogenstad force-pushed the pog-query-convert-response-IFC-1479 branch 2 times, most recently from b99ecdd to 42c6855 Compare April 30, 2025 14:00
@ogenstad ogenstad force-pushed the pog-query-convert-response-IFC-1479 branch from 42c6855 to c3d2199 Compare April 30, 2025 14:00
@dgarros dgarros merged commit 1f4588d into stable Apr 30, 2025
35 checks passed
@dgarros dgarros deleted the pog-query-convert-response-IFC-1479 branch April 30, 2025 22:06
@ogenstad ogenstad mentioned this pull request May 1, 2025
Closed
@ogenstad ogenstad mentioned this pull request May 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajtmccarty ajtmccarty ajtmccarty approved these changes

Assignees

No one assigned

Labels

group/backend Issue related to the backend (API Server, Git Agent) type/documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ogenstad @ajtmccarty @dgarros