Skip to content

Reenable convert query test for transforms and fix code #6456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Reenable convert query test for transforms and fix code #6456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions backend/infrahub/proposed_change/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1222,6 +1222,9 @@ async def refresh_artifacts(
file_path {
value
}
convert_query_response {
value
}
}
repository {
node {
Expand Down Expand Up @@ -1429,6 +1432,9 @@ def _parse_artifact_definitions(definitions: list[dict]) -> list[ProposedChangeA
elif artifact_definition.transform_kind == InfrahubKind.TRANSFORMPYTHON:
artifact_definition.class_name = definition["node"]["transformation"]["node"]["class_name"]["value"]
artifact_definition.file_path = definition["node"]["transformation"]["node"]["file_path"]["value"]
artifact_definition.convert_query_response = definition["node"]["transformation"]["node"][
"convert_query_response"
]["value"]

parsed.append(artifact_definition)

Expand Down
4 changes: 1 addition & 3 deletions ...ests/fixtures/repos/car-dealership/initial__main/transforms/converted_person_with_cars.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ class ConvertedPersonWith(InfrahubTransform):
async def transform(self, data: dict[str, Any]) -> dict[str, Any]:
node_id = data["TestingPerson"]["edges"][0]["node"]["id"]

person = self.store.get(key=node_id, kind="TestingPerson", raise_when_missing=False)
if not person:
person = await self.client.get(kind="TestingPerson", id=node_id)
person = self.store.get(key=node_id, kind="TestingPerson")

return {"name": person.name.value, "age": person.age.value}
Loading