Skip to content

Conversation

@LucasG0
Copy link
Contributor

@LucasG0 LucasG0 commented May 23, 2025

Trigger loading objects definedi in the configuration (infrahub.yml file) when the repository is getting synced.

Corresponding sdk PR: opsmill/infrahub-sdk-python#422

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label May 23, 2025
@LucasG0 LucasG0 force-pushed the lgu-load-git-data branch from 7dcf089 to 9d619b7 Compare May 23, 2025 13:14
@codspeed-hq
Copy link

codspeed-hq bot commented May 23, 2025

CodSpeed Performance Report

Merging #6527 will not alter performance

Comparing lgu-load-git-data (b1cdb2d) with develop (93a068d)

Summary

✅ 10 untouched benchmarks

@LucasG0 LucasG0 force-pushed the lgu-load-git-data branch 2 times, most recently from 9d81ab4 to 02d9468 Compare May 25, 2025 18:50
@LucasG0 LucasG0 force-pushed the lgu-load-git-data branch 4 times, most recently from 7cdfc1a to e2a62a0 Compare May 26, 2025 08:41
@LucasG0 LucasG0 force-pushed the lgu-load-git-data branch 5 times, most recently from 87bda9f to e793eaf Compare May 26, 2025 11:29
@LucasG0 LucasG0 marked this pull request as ready for review May 26, 2025 11:50
@LucasG0 LucasG0 requested a review from a team as a code owner May 26, 2025 11:50
@LucasG0 LucasG0 requested a review from dgarros May 26, 2025 11:50
@LucasG0 LucasG0 force-pushed the lgu-load-git-data branch 5 times, most recently from a58bc7e to dc39125 Compare May 26, 2025 12:40
@LucasG0 LucasG0 requested review from a team as code owners May 26, 2025 12:40
@github-actions github-actions bot added the type/documentation Improvements or additions to documentation label May 26, 2025
@LucasG0 LucasG0 force-pushed the lgu-load-git-data branch from dc39125 to 2e90000 Compare May 26, 2025 13:11
Copy link
Contributor

@ogenstad ogenstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a few comments.

),
],
optional=False,
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the infrahub/actions/schema.py I defined Dropdowns in a different way so that we have them as an Enum that can be used elsewhere for verification is needed. I'm not sure this is needed here but just wanted to highlight that as a possibility.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I think I'll keep the current way here, but good to know

@LucasG0 LucasG0 force-pushed the lgu-load-git-data branch from 388749d to b1cdb2d Compare May 26, 2025 14:38
@LucasG0 LucasG0 merged commit 001b8ff into develop May 26, 2025
31 checks passed
@LucasG0 LucasG0 deleted the lgu-load-git-data branch May 26, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

group/backend Issue related to the backend (API Server, Git Agent) type/documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants