-
Notifications
You must be signed in to change notification settings - Fork 35
Allow to load data from git repo #6527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7dcf089 to
9d619b7
Compare
CodSpeed Performance ReportMerging #6527 will not alter performanceComparing Summary
|
9d81ab4 to
02d9468
Compare
backend/tests/fixtures/repos/car-dealership/initial__main/.infrahub.yml
Outdated
Show resolved
Hide resolved
7cdfc1a to
e2a62a0
Compare
87bda9f to
e793eaf
Compare
a58bc7e to
dc39125
Compare
dc39125 to
2e90000
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added a few comments.
| ), | ||
| ], | ||
| optional=False, | ||
| ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the infrahub/actions/schema.py I defined Dropdowns in a different way so that we have them as an Enum that can be used elsewhere for verification is needed. I'm not sure this is needed here but just wanted to highlight that as a possibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I think I'll keep the current way here, but good to know
388749d to
b1cdb2d
Compare
Trigger loading objects definedi in the configuration (infrahub.yml file) when the repository is getting synced.
Corresponding sdk PR: opsmill/infrahub-sdk-python#422