Skip to content

Conversation

@petercrocker
Copy link
Contributor

@petercrocker petercrocker commented Aug 7, 2025

discovery of the repository configuration file named either .infrahub.yml or .infrahub.yaml

Summary by CodeRabbit

  • Bug Fixes
    • Improved detection of repository configuration files by supporting both .infrahub.yml and .infrahub.yaml formats, with preference given to .infrahub.yml when both are present. This affects both repository configuration loading and user test execution.

@petercrocker petercrocker requested a review from a team as a code owner August 7, 2025 19:59
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 7, 2025

Walkthrough

The changes update logic in two backend modules to detect and prefer either .infrahub.yml or .infrahub.yaml configuration files. Both modules now check for both file extensions, preferring .infrahub.yml when both are present, and handle the absence of both files with appropriate messaging or error handling.

Changes

Cohort / File(s) Change Summary
Repository Config File Detection
backend/infrahub/git/integrator.py
Enhanced get_repository_config to check for both .infrahub.yml and .infrahub.yaml, preferring .yml.
Test Config File Detection
backend/infrahub/proposed_change/tasks.py
Updated _execute to select between .infrahub.yml and .infrahub.yaml for test configuration, preferring .yml. Added error handling for missing config file.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d7c4e0f and dcde6fe.

📒 Files selected for processing (1)
  • backend/infrahub/proposed_change/tasks.py (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • backend/infrahub/proposed_change/tasks.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: E2E-testing-version-upgrade / From 1.1.0
  • GitHub Check: validate-generated-documentation
  • GitHub Check: backend-docker-integration
  • GitHub Check: backend-tests-functional
  • GitHub Check: backend-benchmark
  • GitHub Check: E2E-testing-playwright
  • GitHub Check: backend-tests-unit
  • GitHub Check: backend-tests-integration
  • GitHub Check: Cloudflare Pages
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pmc-infrahub-yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Aug 7, 2025
@petercrocker
Copy link
Contributor Author

Related: opsmill/infrahub-sdk-python#490

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 7, 2025

CodSpeed Performance Report

Merging #6990 will not alter performance

Comparing pmc-infrahub-yaml (dcde6fe) with develop (2551120)

Summary

✅ 10 untouched benchmarks

@petercrocker
Copy link
Contributor Author

Tested locally:

2025-08-07T22:33:41.658324Z [info     ] create_repository              [infrahub] app=infrahub.api name=test request_id=8c8c7f66d1f640169d9e9f4c09419319 worker=f650e16d-2124-4d42-9df4-5058349c5130
2025-08-07T22:33:44.780946Z [info     ] schema_load_request            [infrahub] app=infrahub.api branch=main request_id=331e17cb042c41278018faa779728c17 worker=9c9cdc3a-7d8e-4677-ae24-ce4d239a2068
2025-08-07T22:33:47.427667Z [info     ] Schema has diff, will need to be updated [infrahub] app=infrahub.api branch=main diff=['DcimDevicePlatform', 'DcimGenericObject', 'DcimNetworkDevice', 'DcimOS', 'LocationCountry', 'LocationGeneric', 'LocationRegion', 'LocationSite', 'OrganizationGeneric', 'OrganizationManufacturer'] request_id=331e17cb042c41278018faa779728c17 worker=9c9cdc3a-7d8e-4677-ae24-ce4d239a2068
2025-08-07T22:33:48.746838Z [info     ] Loading schema from DB         [infrahub] app=infrahub.api request_id=331e17cb042c41278018faa779728c17 schema_to_update=['DcimDevicePlatform', 'DcimNetworkDevice', 'DcimOS', 'LocationCountry', 'LocationRegion', 'LocationSite', 'OrganizationManufacturer', 'DcimGenericObject', 'LocationGeneric', 'OrganizationGeneric'] worker=9c9cdc3a-7d8e-4677-ae24-ce4d239a2068
2025-08-07T22:33:50.697576Z [info     ] Schema has been updated        [infrahub] app=infrahub.api branch=main hash=d1a512ae2e5ff7a6c691c14f99a1df36 request_id=331e17cb042c41278018faa779728c17 worker=9c9cdc3a-7d8e-4677-ae24-ce4d239a2068

@petercrocker petercrocker merged commit a26376d into develop Aug 7, 2025
35 checks passed
@petercrocker petercrocker deleted the pmc-infrahub-yaml branch August 7, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

group/backend Issue related to the backend (API Server, Git Agent)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Import error due to invalid .infrahub.yml extension

2 participants