-
Notifications
You must be signed in to change notification settings - Fork 35
Update frontend dependencies #7317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe PR updates frontend/app/biome.jsonc (adds nursery keys Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
frontend/app/package.json (1)
126-133: Confirm compatibility: [email protected] vs React 19
The OneGraph [email protected] plugin predates React 19 and lists @graphiql/react@^0.37.0 (React ≤17) as a peer; forcing react/react-dom 19.2.0 may break it. Upgrade to @graphiql/plugin-explorer (supports React ^18||^19) or pin to a React range it supports.
🧹 Nitpick comments (1)
frontend/app/package.json (1)
98-99: Move build-time tooling to devDependenciesVite, @vitejs/plugin-react, and @tailwindcss/vite are build-only; shifting them to devDependencies avoids shipping them in production installs.
Apply this diff:
"dependencies": { @@ - "@tailwindcss/vite": "^4.1.14", @@ - "@vitejs/plugin-react": "^5.0.4", @@ - "vite": "^7.1.9", + // (moved to devDependencies) }, "devDependencies": { @@ + "@tailwindcss/vite": "^4.1.14", + "@vitejs/plugin-react": "^5.0.4", + "vite": "^7.1.9",Also applies to: 55-55, 50-50
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
frontend/app/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
frontend/app/biome.jsonc(1 hunks)frontend/app/package.json(4 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
frontend/app/package.json
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use npm scripts (
npm start,npm test,npm run build) infrontend/app/
Files:
frontend/app/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: E2E-testing-version-upgrade / From 1.3.0
- GitHub Check: E2E-testing-invoke-demo-start
- GitHub Check: E2E-testing-playwright
🔇 Additional comments (3)
frontend/app/biome.jsonc (1)
108-108: LGTM: Biome rule toggle is fineDisabling useConsistentArrowReturn matches Biome 2.x rule names and your current version.
frontend/app/package.json (2)
74-74: Confirm React 19 peerDependenciesPeerDeps for:
- @headlessui/react v2.2.9
- react-aria-components v1.13.0
- react-error-boundary v6.0.0
- @tanstack/react-query v5.90.x
already include React 19; please verify the same for react-router v7.9.3.
55-55: Compatibility confirmed — @vitejs/plugin-react@5 peerDependencies include^7.0.0, and Vitest^3.2.4(v3.2+) adds Vite 7 support.
|
Does this replace #7191? |
4f411d8 to
016ba3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
frontend/app/src/shared/components/ui/alert.tsx (1)
106-109: Clean refactor to optional chaining.The use of optional chaining for the callback invocations is idiomatic and improves readability while maintaining the same behavior.
If you want to further improve type safety, consider replacing the generic
Functiontype with more specific signatures:type AlertProps = { - closeToast?: Function; - onDismiss?: Function; + closeToast?: () => void; + onDismiss?: () => void; message?: ReactNode; details?: string; type?: ALERT_TYPES; };
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
frontend/app/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (5)
frontend/app/biome.jsonc(2 hunks)frontend/app/index.html(1 hunks)frontend/app/package.json(4 hunks)frontend/app/src/shared/components/buttons/button.tsx(1 hunks)frontend/app/src/shared/components/ui/alert.tsx(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- frontend/app/index.html
🚧 Files skipped from review as they are similar to previous changes (2)
- frontend/app/biome.jsonc
- frontend/app/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: E2E-testing-version-upgrade / From 1.3.0
- GitHub Check: E2E-testing-playwright
- GitHub Check: E2E-testing-invoke-demo-start
🔇 Additional comments (1)
frontend/app/src/shared/components/buttons/button.tsx (1)
96-102: LGTM! Consistent with the alert component refactor.The optional chaining pattern matches the approach used in
alert.tsxand correctly handles the optionalonClickcallback.
Summary by CodeRabbit