Skip to content

Conversation

@bilalabbad
Copy link
Contributor

@bilalabbad bilalabbad commented Oct 3, 2025

Summary by CodeRabbit

  • Chores
    • Updated frontend dependencies (React, Vite, Tailwind, CodeMirror, Headless UI, TanStack, and related tooling) to newer minor/patch versions for stability and compatibility.
  • Style
    • Adjusted linting rules (disabled two specific checks) and enabled HTML formatting; normalized HTML head tag formatting.
  • Bug Fixes
    • Made callback/event invocations safer when handlers are absent to avoid potential runtime issues.
  • Notes
    • No user-facing feature changes in this release.

@bilalabbad bilalabbad self-assigned this Oct 3, 2025
@bilalabbad bilalabbad requested a review from a team as a code owner October 3, 2025 14:29
@bilalabbad bilalabbad added the ci/skip-changelog Don't include this PR in the changelog label Oct 3, 2025
@github-actions github-actions bot added the group/frontend Issue related to the frontend (React) label Oct 3, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 3, 2025

Walkthrough

The PR updates frontend/app/biome.jsonc (adds nursery keys useConsistentArrowReturn: "off", noReactForwardRef: "off", and html.formatter.enabled: true), upgrades many frontend and devtool dependency versions in frontend/app/package.json, normalizes self-closing tags in frontend/app/index.html, and replaces manual callback checks with optional chaining in two components (button.tsx and alert.tsx). No public API signatures were changed.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly captures the primary change of updating frontend dependencies and directly reflects the majority of modifications made to package.json version upgrades, providing a clear and concise summary of the pull request’s intent.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bab-update-frontend-deps

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 016ba3e and fd44627.

📒 Files selected for processing (1)
  • frontend/app/biome.jsonc (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • frontend/app/biome.jsonc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
frontend/app/package.json (1)

126-133: Confirm compatibility: [email protected] vs React 19
The OneGraph [email protected] plugin predates React 19 and lists @graphiql/react@^0.37.0 (React ≤17) as a peer; forcing react/react-dom 19.2.0 may break it. Upgrade to @graphiql/plugin-explorer (supports React ^18||^19) or pin to a React range it supports.

🧹 Nitpick comments (1)
frontend/app/package.json (1)

98-99: Move build-time tooling to devDependencies

Vite, @vitejs/plugin-react, and @tailwindcss/vite are build-only; shifting them to devDependencies avoids shipping them in production installs.

Apply this diff:

   "dependencies": {
@@
-    "@tailwindcss/vite": "^4.1.14",
@@
-    "@vitejs/plugin-react": "^5.0.4",
@@
-    "vite": "^7.1.9",
+    // (moved to devDependencies)
   },
   "devDependencies": {
@@
+    "@tailwindcss/vite": "^4.1.14",
+    "@vitejs/plugin-react": "^5.0.4",
+    "vite": "^7.1.9",

Also applies to: 55-55, 50-50

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e2c06c6 and 4f411d8.

⛔ Files ignored due to path filters (1)
  • frontend/app/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • frontend/app/biome.jsonc (1 hunks)
  • frontend/app/package.json (4 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
frontend/app/package.json

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use npm scripts (npm start, npm test, npm run build) in frontend/app/

Files:

  • frontend/app/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: E2E-testing-version-upgrade / From 1.3.0
  • GitHub Check: E2E-testing-invoke-demo-start
  • GitHub Check: E2E-testing-playwright
🔇 Additional comments (3)
frontend/app/biome.jsonc (1)

108-108: LGTM: Biome rule toggle is fine

Disabling useConsistentArrowReturn matches Biome 2.x rule names and your current version.

frontend/app/package.json (2)

74-74: Confirm React 19 peerDependencies

PeerDeps for:

  • @headlessui/react v2.2.9
  • react-aria-components v1.13.0
  • react-error-boundary v6.0.0
  • @tanstack/react-query v5.90.x
    already include React 19; please verify the same for react-router v7.9.3.

55-55: Compatibility confirmed — @vitejs/plugin-react@5 peerDependencies include ^7.0.0, and Vitest ^3.2.4 (v3.2+) adds Vite 7 support.

@ogenstad
Copy link
Contributor

ogenstad commented Oct 7, 2025

Does this replace #7191?

@bilalabbad bilalabbad force-pushed the bab-update-frontend-deps branch from 4f411d8 to 016ba3e Compare October 9, 2025 17:54
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
frontend/app/src/shared/components/ui/alert.tsx (1)

106-109: Clean refactor to optional chaining.

The use of optional chaining for the callback invocations is idiomatic and improves readability while maintaining the same behavior.

If you want to further improve type safety, consider replacing the generic Function type with more specific signatures:

 type AlertProps = {
-  closeToast?: Function;
-  onDismiss?: Function;
+  closeToast?: () => void;
+  onDismiss?: () => void;
   message?: ReactNode;
   details?: string;
   type?: ALERT_TYPES;
 };
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f411d8 and 016ba3e.

⛔ Files ignored due to path filters (1)
  • frontend/app/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (5)
  • frontend/app/biome.jsonc (2 hunks)
  • frontend/app/index.html (1 hunks)
  • frontend/app/package.json (4 hunks)
  • frontend/app/src/shared/components/buttons/button.tsx (1 hunks)
  • frontend/app/src/shared/components/ui/alert.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • frontend/app/index.html
🚧 Files skipped from review as they are similar to previous changes (2)
  • frontend/app/biome.jsonc
  • frontend/app/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: E2E-testing-version-upgrade / From 1.3.0
  • GitHub Check: E2E-testing-playwright
  • GitHub Check: E2E-testing-invoke-demo-start
🔇 Additional comments (1)
frontend/app/src/shared/components/buttons/button.tsx (1)

96-102: LGTM! Consistent with the alert component refactor.

The optional chaining pattern matches the approach used in alert.tsx and correctly handles the optional onClick callback.

@bilalabbad bilalabbad merged commit fcdbb2c into stable Oct 10, 2025
35 checks passed
@bilalabbad bilalabbad deleted the bab-update-frontend-deps branch October 10, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/skip-changelog Don't include this PR in the changelog group/frontend Issue related to the frontend (React)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants