Draft: Template profile support #7361
Conversation
github-actions
bot
added
group/backend
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CodSpeed Performance ReportMerging #7361 will not alter performanceComparing Summary
|
| // Get the profile schema for the current kind | ||
| const profileSchema = profileSchemas.find((profileSchema) => profileSchema.name === profile); | ||
| const profileSchema = profileSchemas.find( | ||
| (profileSchema) => profileSchema.name === profile?.replace("Template", "") |
There was a problem hiding this comment.
I don't understand why we need profile?.replace("Template", "")?
| is_template = None | ||
| if node_attr.source_id: | ||
| await node_attr.get_source(db=self.db) | ||
| if isinstance(node_attr.source.get_schema(), TemplateSchema): | ||
| is_template = True | ||
| if node_attr.is_from_profile or node_attr.is_default or is_template: |
There was a problem hiding this comment.
does this mean that profile values will override template values? if so, that's not what I would expect, but maybe you could explain what the expected behavior is in the PR description
I would think that template values would take precedence over profile values. and I'd think that adding the profiles relationship to a template would be enough and this change to NodeProfilesApplier wouldn't be necessary, but I could definitely be missing something
…a node from template.
…ling in templates
No description provided.