Skip to content

Conversation

@ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Jan 5, 2026

Summary by CodeRabbit

  • Chores
    • Updated internal type checking configuration and improved type safety annotations for better code quality.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 5, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request makes two type-checking related changes: First, it removes an invalid-argument-type ignore rule from the pyproject.toml configuration for the python_testcontainers path, narrowing the scope of previously ignored type-check rules. Second, it updates the type annotation for the variadic keyword arguments parameter in the InfrahubPerformanceTest.add_measurement method from str | float to dict[str, float]. Both changes are type-annotation adjustments with no modifications to runtime behavior.


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e0abdc and 4797a80.

📒 Files selected for processing (2)
  • pyproject.toml
  • python_testcontainers/infrahub_testcontainers/performance_test.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 5, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing pog-testcontainers-argument-type (4797a80) with release-1.7 (2e0abdc)

Summary

✅ 12 untouched benchmarks

@ogenstad ogenstad force-pushed the pog-testcontainers-argument-type branch from 985af39 to 4797a80 Compare January 7, 2026 15:47
@ogenstad ogenstad marked this pull request as ready for review January 8, 2026 06:39
@ogenstad ogenstad requested a review from a team as a code owner January 8, 2026 06:39
@ogenstad ogenstad merged commit 5465cd0 into release-1.7 Jan 8, 2026
83 of 84 checks passed
@ogenstad ogenstad deleted the pog-testcontainers-argument-type branch January 8, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants