Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Excel supports naming a formula via its Name Manager. The current version of this library only supports adjusting defined names that name a cell. Also it adjusts all names not the ones that require adjustments.
For example:
Table1!A3is changed toTable1!A4even if the row is inserted in Table2some_table[col_name]*IF(Table1!$D$6="",1,(Table!$D$6/Table!$D$5))is changed tosome_table[col_name]*IF(Table1!$D$6="",1,(Table!$D$6/Table!$D$7even though the change occurred in Table2 and the resulting name causes an error when opening excelThis PR adds support for Formulas in defined names such that the above examples are adjusted as expected
I have adjusted the test case for named tables to contain two sheets and a formula
I have adjusted the test case for the pageBreakOption to actually change the size of the page and ajdusted the code to update the pageBreak. Maybe @jdugh can comment if this still supports his use cases.