Skip to content

[FSSDK-11731] windows version update #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 52 additions & 1 deletion .github/workflows/csharp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
netFrameworksAndUnitTest:
name: Build Framework & Run Unit Tests
needs: [ lintCodebase ]
runs-on: windows-2019 # required version for Framework 4.0
runs-on: windows-2022 # required version for Framework 4.0
env:
REPO_SLUG: ${{ github.repository }}
BUILD_NUMBER: ${{ github.run_id }}
Expand All @@ -44,6 +44,57 @@ jobs:
uses: microsoft/setup-msbuild@v1
- name: Setup NuGet
uses: NuGet/setup-nuget@v1
- name: Download and Install .NET Framework Reference Assemblies
run: |
# Create temp directory
New-Item -ItemType Directory -Path "temp_ref_assemblies" -Force

# Download .NET 4.0 Reference Assemblies
echo "Downloading .NET 4.0 Reference Assemblies..."
Invoke-WebRequest -Uri "https://www.nuget.org/api/v2/package/Microsoft.NETFramework.ReferenceAssemblies.net40/1.0.3" -OutFile "temp_ref_assemblies/net40_ref.zip"

# Download .NET 4.5 Reference Assemblies
echo "Downloading .NET 4.5 Reference Assemblies..."
Invoke-WebRequest -Uri "https://www.nuget.org/api/v2/package/Microsoft.NETFramework.ReferenceAssemblies.net45/1.0.3" -OutFile "temp_ref_assemblies/net45_ref.zip"

# Extract and install .NET 4.0
echo "Installing .NET 4.0 Reference Assemblies..."
Expand-Archive -Path "temp_ref_assemblies/net40_ref.zip" -DestinationPath "temp_ref_assemblies/net40" -Force
if (Test-Path "temp_ref_assemblies/net40/build/.NETFramework/v4.0") {
Copy-Item -Path "temp_ref_assemblies/net40/build/.NETFramework/v4.0" -Destination "C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\" -Recurse -Force
echo "✓ .NET 4.0 Reference Assemblies installed"
}

# Extract and install .NET 4.5
echo "Installing .NET 4.5 Reference Assemblies..."
Expand-Archive -Path "temp_ref_assemblies/net45_ref.zip" -DestinationPath "temp_ref_assemblies/net45" -Force
if (Test-Path "temp_ref_assemblies/net45/build/.NETFramework/v4.5") {
Copy-Item -Path "temp_ref_assemblies/net45/build/.NETFramework/v4.5" -Destination "C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\" -Recurse -Force
echo "✓ .NET 4.5 Reference Assemblies installed"
}

# Verify installations
echo "Verifying installations..."
if (Test-Path "C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.0\mscorlib.dll") {
echo "✓ .NET 4.0 mscorlib.dll found"
} else {
echo "✗ .NET 4.0 mscorlib.dll missing"
}
if (Test-Path "C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5\mscorlib.dll") {
echo "✓ .NET 4.5 mscorlib.dll found"
} else {
echo "✗ .NET 4.5 mscorlib.dll missing"
}

# Show what we have available now
echo "Final targeting pack listing..."
if (Test-Path "C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework") {
dir "C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework"
}

# Cleanup
Remove-Item -Path "temp_ref_assemblies" -Recurse -Force
continue-on-error: true
- name: Restore NuGet packages
run: nuget restore ./OptimizelySDK.NETFramework.sln
- name: Build & strongly name assemblies
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/csharp_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
buildFrameworkVersions:
name: Build Framework versions
needs: [ variables ]
runs-on: windows-2019 # required version for Framework 4.0
runs-on: windows-2022 # required version for Framework 4.0
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand All @@ -55,7 +55,7 @@ jobs:
buildStandard16:
name: Build Standard 1.6 version
needs: [ variables ]
runs-on: windows-latest
runs-on: windows-2022
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand All @@ -77,7 +77,7 @@ jobs:
buildStandard20:
name: Build Standard 2.0 version
needs: [ variables ]
runs-on: windows-latest
runs-on: windows-2022
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sonarqube.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
jobs:
build:
name: Build
runs-on: windows-latest
runs-on: windows-2022
steps:
- name: Set up JDK 11
uses: actions/setup-java@v4
Expand Down
Loading