Skip to content

Commit 10d0bfa

Browse files
authored
feat: Upgrade typescript-eslint dependencies to support TS 4.0.3 (#676)
* Fix typescript upgrade * Update eslint plugin and parser + edit eslint rules * Update package.json scrint to run lint after tests
1 parent 64d77e5 commit 10d0bfa

File tree

3 files changed

+47
-25
lines changed

3 files changed

+47
-25
lines changed

packages/datafile-manager/.eslintrc.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ module.exports = {
4040
'@typescript-eslint/camelcase': 'off',
4141
'@typescript-eslint/no-empty-function': 'off',
4242
'@typescript-eslint/no-explicit-any': 'off',
43-
'@typescript-eslint/no-non-null-assertion': 'off'
43+
'@typescript-eslint/no-non-null-assertion': 'off',
44+
'@typescript-eslint/explicit-module-boundary-types': 'off'
4445
},
4546
};

packages/datafile-manager/package-lock.json

Lines changed: 40 additions & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/datafile-manager/package.json

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,13 @@
3030
"access": "public"
3131
},
3232
"devDependencies": {
33+
"@react-native-async-storage/async-storage": "^1.2.0",
3334
"@types/jest": "^26.0.3",
3435
"@types/nise": "^1.4.0",
3536
"@types/nock": "^9.3.1",
3637
"@types/node": "^11.11.7",
37-
"@typescript-eslint/eslint-plugin": "^2.23.0",
38-
"@typescript-eslint/parser": "^2.23.0",
38+
"@typescript-eslint/eslint-plugin": "^3.3.0",
39+
"@typescript-eslint/parser": "^3.3.0",
3940
"eslint": "^6.8.0",
4041
"eslint-config-prettier": "^6.10.0",
4142
"eslint-plugin-prettier": "^3.1.2",
@@ -44,8 +45,7 @@
4445
"nock": "^10.0.6",
4546
"prettier": "^1.19.1",
4647
"ts-jest": "^27.0.1",
47-
"typescript": "^4.0.3",
48-
"@react-native-async-storage/async-storage": "^1.2.0"
48+
"typescript": "^4.0.3"
4949
},
5050
"dependencies": {
5151
"@optimizely/js-sdk-logging": "^0.1.0",
@@ -58,6 +58,7 @@
5858
"scripts": {
5959
"lint": "tsc --noEmit && eslint --fix 'src/**/*.ts' '__test__/**/*.ts'",
6060
"test": "jest",
61+
"posttest": "npm run lint",
6162
"tsc": "rm -rf lib && tsc",
6263
"prepublishOnly": "npm run lint && npm test && npm run tsc"
6364
}

0 commit comments

Comments
 (0)