serialize event count in store function call #1065
Merged
+15
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if multiple events are processed concurrently, all event process request might read the initial store size and write to the store, potentially exceeding the store size limit. Serializing the store size read should fix this. Once the size is loaded in memory, further event process read should just read the in memory value
raju-opti
requested review from
Copilot and
junaed-optimizely
and removed request for
Copilot
junaed-optimizely
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if multiple events are processed concurrently, all event process request might read the initial store size and write to the store, potentially exceeding the store size limit. Serializing the store size read should fix this. Once the size is loaded in memory, further event process read should just read the in memory value