Skip to content

[FSSDK-10867] ensure odpManager.setVuid is done before resolving onReady #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2024
Merged

[FSSDK-10867] ensure odpManager.setVuid is done before resolving onReady #956

merged 1 commit into from
Nov 6, 2024

Conversation

raju-opti
Copy link
Contributor

Summary

  • ensure odpManager.setVuid is done before resolving onReady so that identify event contains the vuid.

Test plan

  • existing tests should pass

Issues

  • FSSDK-10867

@raju-opti raju-opti requested a review from a team as a code owner November 6, 2024 14:01
@coveralls
Copy link

Coverage Status

coverage: 90.541% (-0.04%) from 90.579%
when pulling 4eb8e53 on raju/vuid_identify
into 8feb1c0 on 5.x.x.

junaed-optimizely
junaed-optimizely reviewed Nov 6, 2024
View reviewed changes
junaed-optimizely
junaed-optimizely approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@junaed-optimizely junaed-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raju-opti raju-opti merged commit 973cbf7 into 5.x.x Nov 6, 2024
14 of 19 checks passed
@raju-opti raju-opti deleted the raju/vuid_identify branch November 6, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junaed-optimizely junaed-optimizely junaed-optimizely approved these changes

@mikechu-optimizely mikechu-optimizely Awaiting requested review from mikechu-optimizely

Assignees

@raju-opti raju-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raju-opti @coveralls @junaed-optimizely