[FSSDK-10439] client provider test

[junaed-optimizely]

Summary

Significant improvements were made to the test coverage of the "Client" and "Provider files.

• Provider Coverage: Increased from 72.34% to 100%
• Client Coverage: Improved from 81.4% to 99.27% by restructuring and adding tests for various methods
• Test Additions: A total of 52 new tests were added, covering previously missing cases and deprecated API updates.

The coverage reports have been generated with the help of "Istanbul" that is the default coverage tool of "Jest". Here are the commands that I have used to generate the coverage report -

# for client
npx jest --coverage -- client.spec.ts
# and for provider
npx jest --coverage -- provider.spec.tsx

Test plan

A total of 52 new tests were added, covering previously missing cases and deprecated API updates.

Issues

• FSSDK-10439

[mikechu-optimizely]

What are your thoughts on splitting out client.spec.ts into separate files? Along with less cognitive load for review/maintenance, I think we get some speed of execution benefit too. 🤔

Otherwise, LGTM

[mikechu-optimizely]

NIT: I like a bit of whitespace between test blocks, and even to separate the arrange-act-assert within each test. imho

[junaed-optimizely]

NIT: I like a bit of whitespace between test blocks, and even to separate the arrange-act-assert within each test. imho

Thats a good suggestion. Let me do that

[junaed-optimizely]

What are your thoughts on splitting out client.spec.ts into separate files? Along with less cognitive load for review/maintenance, I think we get some speed of execution benefit too. 🤔

Otherwise, LGTM

I like your suggestion. But its not uncommon to have a single test file against a single module. It offers easier context management as well.