Skip to content

[FSSDK-10730] isClientReady logic adjustment #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2024
Merged

[FSSDK-10730] isClientReady logic adjustment #285

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caad5b2
[FSSDK-10730] isClientReady logic adjustment
junaed-optimizely Oct 2, 2024
906faf3
[FSSDK-10730] isClientReady if config ready
junaed-optimizely Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,6 @@ class OptimizelyReactSDKClient implements ReactSDKClient {
});

this._client = optimizely.createInstance(configWithClientInfo);
this.isClientReady = !!configWithClientInfo.datafile;
this.isUsingSdkKey = !!configWithClientInfo.sdkKey;

if (this._client) {
Expand All @@ -251,7 +250,6 @@ class OptimizelyReactSDKClient implements ReactSDKClient {
this.isClientReady = clientResult.success;
this.isUserReady = userResult.success;
const clientAndUserReady = this.isClientReady && this.isUserReady;

this.clientAndUserReadyPromiseFulfilled = true;

return {
Expand Down
Loading