Merged
Conversation
Member
Author
|
@sawa3030 Could you review this PR? |
sawa3030
reviewed
Feb 25, 2026
Collaborator
sawa3030
left a comment
sawa3030
left a comment
There was a problem hiding this comment.
It almost LGTM. I just left one minor comment.
Collaborator
There was a problem hiding this comment.
[nit] It might be helpful to mention the required Optuna version for running the tests. For example: “Please use Optuna v4.8.0 or later to run the tests.”
Member
Author
There was a problem hiding this comment.
Thank you for your suggestion. Updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor Agreements
Please read the contributor agreements and if you agree, please click the checkbox below.
Tip
Please follow the Quick TODO list to smoothly merge your PR.
Motivation & Description of the changes
example.pyfor AutoSamplerSamplerTestCase(AddSamplerTestCaseclass inoptuna.testing packageoptuna#6424). Note that this requiresoptuna>=4.8autosampler.pngtoauto_sampler.pngfor consistency