Skip to content

urgent fix for Hub/Spoke after - Automation Toolkit Release v2025.1.3 #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2025
Merged

urgent fix for Hub/Spoke after - Automation Toolkit Release v2025.1.3 #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39a6ad4
urgent fix for Hub/Spoke after - Automation Toolkit Release v2025.1.3
xs2suruchi Aug 7, 2025
2f5d886
Merge remote-tracking branch 'origin/develop' into develop
xs2suruchi Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cd3_automation_toolkit/Network/BaseNetwork/create_major_objects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,8 +603,8 @@ def processVCN(tempStr):
str(df.loc[i, 'CIDR Blocks']).lower() == 'nan' or str(df.loc[i, 'DRG Required']).lower() == 'nan' or str(
df.loc[i, 'IGW Required']).lower() == 'nan' or
str(df.loc[i, 'NGW Required']).lower() == 'nan' or str(
df.loc[i, 'SGW Required']).lower() == 'nan' or str(df.loc[i, 'LPG Required']).lower() == 'nan' or
str(df.loc[i, 'Hub/Spoke/Peer/None']).lower() == 'nan'):
df.loc[i, 'SGW Required']).lower() == 'nan' or str(df.loc[i, 'LPG Required']).lower() == 'nan'):
#or str(df.loc[i, 'Hub/Spoke/Peer/None']).lower() == 'nan'):
print("\nColumn Values(except dns_label) or Rows cannot be left empty in VCNs sheet in CD3..exiting...")
exit(1)

Expand Down
2 changes: 1 addition & 1 deletion cd3_automation_toolkit/cd3Validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ def validate_vcns(filename, comp_ids, vcnobj):# config): # ,vcn_cidrs,vcn_compa
# Check for null values and display appropriate message
for j in dfv.keys():
if (str(dfv[j][i]).strip() == "NaN" or str(dfv[j][i]).strip() == "nan" or str(dfv[j][i]).strip() == ""):
if j == 'DNS Label' or commonTools.check_column_headers(j) in commonTools.tagColumns or "ipv6" in j.lower():
if j == 'DNS Label' or commonTools.check_column_headers(j) in commonTools.tagColumns or "ipv6" in j.lower() or "Hub/Spoke" in j:
continue
else:
log(f'ROW {count+2} : Empty value at column "{j}".')
Expand Down