Added global tolerations for logan and mgmnt-agent in the Helm charts #125
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
| | deployment.security.fsGroup | int | `2000` | | | ||
| | deployment.security.runAsGroup | int | `2000` | | | ||
| | deployment.security.runAsUser | int | `1000` | | | ||
| | deployment.storageClass | string | `nil` | | |
There was a problem hiding this comment.
let's not update unrelated properties in this transaction.
| | fluentd.eksControlPlane.logs | object | `{"apiserver":{"cwLogStreamName":"kube-apiserver","multilineStartRegExp":"/^\\S\\d{2}\\d{2}\\s+[^\\:]+:[^\\:]+:[^\\.]+\\.\\d{0,3}/","objectKey":".*?kube-apiserver/","ociLALogSourceName":"Kubernetes API Server Logs","sqsQueue":"apiserver"},"audit":{"objectKey":".*?kube-apiserver-audit","ociLALogSourceName":"Kubernetes Audit Logs","sqsQueue":"audit"},"authenticator":{"cwLogStreamName":"authenticator","multilineStartRegExp":"/^time=/","objectKey":".*?authenticator","ociLALogSourceName":"AWS EKS Authenticator Logs","sqsQueue":"authenticator"},"cloudcontrollermanager":{"cwLogStreamName":"cloud-controller-manager","multilineStartRegExp":"/^\\S\\d{2}\\d{2}\\s+[^\\:]+:[^\\:]+:[^\\.]+\\.\\d{0,3}/","objectKey":".*?cloud-controller-manager","ociLALogSourceName":"Cloud Controller Manager Logs","sqsQueue":"cloud-controller-manager"},"kubecontrollermanager":{"cwLogStreamName":"kube-controller-manager","multilineStartRegExp":"/^\\S\\d{2}\\d{2}\\s+[^\\:]+:[^\\:]+:[^\\.]+\\.\\d{0,3}/","objectKey":".*?kube-controller-manager","ociLALogSourceName":"Kubernetes Controller Manager Logs","sqsQueue":"kube-controller-manager"},"scheduler":{"cwLogStreamName":"kube-scheduler","multilineStartRegExp":"/^\\S\\d{2}\\d{2}\\s+[^\\:]+:[^\\:]+:[^\\.]+\\.\\d{0,3}/","objectKey":".*?kube-scheduler","ociLALogSourceName":"Kubernetes Scheduler Logs","sqsQueue":"scheduler"}}` | To set timezone override for all eksControlPlane logs (applies only to log records without explicit timezone identifier in the record itself) timezone: | | ||
| | fluentd.eksControlPlane.ociLALogGroupID | string | `nil` | | | ||
| | fluentd.eksControlPlane.region | string | `nil` | | | ||
| | fluentd.eksControlPlane.s3Bucket | string | `nil` | | |
There was a problem hiding this comment.
let's not update unrelated properties here as well.
| effect: NoSchedule | ||
| {{- if .Values.tolerations }} | ||
| {{- toYaml .Values.tolerations | nindent 6 }} | ||
| {{- end }} |
There was a problem hiding this comment.
We need a tier based approach to applying tolerations as toleration requirements for the clients will differ.
Ex - discovery client can run on any host but the logan fluentd clients must be run on every worker node.
These should be a default toleration defined at global scope and additional tolerations for specific clients (mgmt_agent, fluentd, discovery, tcpconnect etc)
Helm should compute the final tolerations for specific client and configure the templates accordingly.
You can refer to #93 to check how we we accept same property at multiple sections and decide on the final one during run time. For timezone we are using priority based approach but for tolerations we will need a consolidation based approach.
Let's also move the current hard-coded tolerations to values.yaml (as default values) so that we remain backward compliant.
- key: node-role.kubernetes.io/master
effect: NoSchedule
- key: node-role.kubernetes.io/control-plane
effect: NoSchedule
There was a problem hiding this comment.
@alcampag can you please address these comments and re-submit.
2 participants
Implement fixes for issue #77