fix TestDeeplyNestedTransactionWithBlockAndWrappedCallback test#43
Closed
jawad-arb123 wants to merge 3 commits intomainfrom
Closed
fix TestDeeplyNestedTransactionWithBlockAndWrappedCallback test#43jawad-arb123 wants to merge 3 commits intomainfrom
jawad-arb123 wants to merge 3 commits intomainfrom
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
jawad-arb123
requested review from
ting-lan-wang
and removed request for
ting-lan-wang
ting-lan-wang
previously approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old test (Postgres assumption):
Expected user2 to still be visible inside the parent transaction after its rollback.
This matches Postgres behavior: rolled-back rows can sometimes still be visible in the same transaction until the outer transaction ends.
New test (Oracle semantics):
Now expects user2 to disappear immediately after rolling back to the savepoint.
Oracle uses undo segments and ROLLBACK TO SAVEPOINT, which permanently discards changes from the inner transaction, so that even the parent can’t see them anymore.