Add tests in associations_many2many_test.go and associations_test.go#59
Merged
shelly-li-sl merged 4 commits intomainfrom Sep 5, 2025
Merged
Add tests in associations_many2many_test.go and associations_test.go#59shelly-li-sl merged 4 commits intomainfrom
shelly-li-sl merged 4 commits intomainfrom
Conversation
shelly-li-sl
reviewed
Sep 3, 2025
| } | ||
| } | ||
|
|
||
| func TestMany2ManyAssociationCountValidation(t *testing.T) { |
Contributor
There was a problem hiding this comment.
This test seems a dup of TestMany2ManyAssociation. Could you double check?
Contributor
Author
There was a problem hiding this comment.
they are similar, but both the tests have diff purposes:
TestMany2ManyAssociation: it has tests of all many-to-many operations (Find, Append, Replace, Delete, Clear) with basic validation.
TestMany2ManyAssociationCountValidation: I am focusing on validating the accuracy of the Count() method and ensuring it matches the actual Find() results after various operations.
Contributor
There was a problem hiding this comment.
thanks for the details!
shelly-li-sl
reviewed
Sep 3, 2025
shelly-li-sl
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add basic association tests for BelongsTo, HasMany, and ManyToMany.
Tests are run using the below conditions:
=== GORM Environment Information ===
Run at : Wed, 03 Sep 2025 20:35:59 +0530
Go version : go1.24.4 (darwin/arm64)
Oracle Database version : Oracle Database 26ai Enterprise Edition Release 26.0.0.0.0 - Development
Version 26.1.0.24.00
Client Driver : godror : v0.49.0+ODPI-5.6.0
Oracle Client library version : 23.3.0.23.09
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: