Skip to content

Fix issue 81 #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 10, 2025
Merged

Fix issue 81 #91

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e16f5f
update clause with custom table name
jawad-arb123 Oct 8, 2025
e98e573
add test for custom table name in update tests
jawad-arb123 Oct 8, 2025
6ca3ece
Merge branch 'main' into fix_issue_81
jawad-arb123 Oct 10, 2025
214a4b7
Uncommented TestToSQL test case (issue #81 resolved)
jawad-arb123 Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions oracle/update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,11 @@ func Update(db *gorm.DB) {
// Always use PL/SQL for RETURNING, just like delete callback
buildUpdatePLSQL(db)
} else {
if updateClause, ok := stmt.Clauses["UPDATE"].Expression.(clause.Update); ok {
if updateClause.Table.Name != "" {
stmt.Table = updateClause.Table.Name
}
}
// Use GORM's standard build for non-RETURNING updates
stmt.Build("UPDATE", "SET", "WHERE")
// Convert values for Oracle
Expand Down
12 changes: 12 additions & 0 deletions tests/update_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,3 +1163,15 @@ func TestUpdateCustomDataType(t *testing.T) {
t.Errorf("failed to update custom data type field: %v", err)
}
}

func TestUpdateWithCustomTableName(t *testing.T) {
Copy link
Contributor

@shelly-li-sl shelly-li-sl Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the issue! Could you please uncomment the related test in TestToSQL in tests/sql_builder_test.go as well? Thanks a lot!

sql := DB.ToSQL(func(tx *gorm.DB) *gorm.DB {
return tx.Clauses(clause.Update{
Table: clause.Table{Name: "custom_update_table"},
}).Where("id = ?", 200).
Updates(&User{Name: "patched", Age: 99})
})

assertEqualSQL(t, `UPDATE "custom_update_table" SET "updated_at"=?,"name"='patched',"age"=99 WHERE id = 200 AND "custom_update_table"."deleted_at" IS NULL`, sql)

}
Loading