Skip to content

regex fix to support table name with alias #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2025
Merged

regex fix to support table name with alias #93

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd4a90a
regex fix to support table name with alias
aarrasseayoub01 Oct 14, 2025
77d5ef2
removing dead code
aarrasseayoub01 Oct 14, 2025
66057ee
removing unnecessary condition
aarrasseayoub01 Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions oracle/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ import (
)

// Identifies the table name alias provided as
// "\"users\" \"u\"" and "\"users\" u". Gorm already handles
// "\"users\" \"u\"" and "\"users\" u" and "\"users\"". Gorm already handles
Copy link
Contributor

@ting-lan-wang ting-lan-wang Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for retracting the approval at last minute.
I’m wondering why we need to specifically handle the case "users" without an alias.
It also looks like issue #71 still remains. Line 60 still appears to be unreachable.

// the other formats like "users u", "users AS u" etc.
var tableRegexp = regexp.MustCompile(`^"(\w+)"\s+"?(\w+)"?$`)
var tableRegexp = regexp.MustCompile(`^"(\w+)"(?:\s+"?(\w+)"?)?$`)

func BeforeQuery(db *gorm.DB) {
if db == nil || db.Statement == nil || db.Statement.TableExpr == nil {
Expand All @@ -64,6 +64,7 @@ func BeforeQuery(db *gorm.DB) {
}
}
}
return
}

// MismatchedCaseHandler handles Oracle Case Insensitivity.
Expand Down
Loading