Skip to content

Conversation

@jakegt1
Copy link
Member

@jakegt1 jakegt1 commented Apr 15, 2025

Wanting some review on this, just thinking about default listen ports, should SSL be enabled (i.e dnf install -y mod_ssl), etc.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 15, 2025
@Djelibeybi
Copy link
Contributor

My immediate reaction was that HTTPS/TLS support would be preferable, but that would require either the creation of self-signed certificates (so that Apache actually starts) or a startup script that checked for the existence of certificates (provided via bind mount or some other mechanism) before enabling TLS support.

Thoughts?

@jakegt1
Copy link
Member Author

jakegt1 commented Apr 16, 2025

My immediate reaction was that HTTPS/TLS support would be preferable, but that would require either the creation of self-signed certificates (so that Apache actually starts) or a startup script that checked for the existence of certificates (provided via bind mount or some other mechanism) before enabling TLS support.

I am happy to do this, although is there any problem for us generating openssl certs? (guess it's at runtime so shouldn't matter..)

@jakegt1
Copy link
Member Author

jakegt1 commented Apr 16, 2025

Have added something simple, and checked that it works.

@jakegt1
Copy link
Member Author

jakegt1 commented Apr 17, 2025

Anything else to do here?

@Djelibeybi
Copy link
Contributor

Can you please rebase this PR? I'll merge it then.

@jakegt1
Copy link
Member Author

jakegt1 commented Apr 23, 2025

Have also made the acme changes (hope they make sense?)

Didn't put a backup file this time.. mainly because i think httpd would still try pick it up.

@jakegt1
Copy link
Member Author

jakegt1 commented Apr 25, 2025

Anything more to do here? I think it's good

@Djelibeybi Djelibeybi merged commit 039d3c3 into oracle:main Apr 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants