Skip to content

Commit 82c7b7a

Browse files
author
Andrija Kolic
committed
[GR-65259] Copy rss and latency into distribution metrics for Barista
PullRequest: graal/20896
2 parents cf80b64 + 889e421 commit 82c7b7a

File tree

3 files changed

+20
-2
lines changed

3 files changed

+20
-2
lines changed

common.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"Jsonnet files should not include this file directly but use ci/common.jsonnet instead."
55
],
66

7-
"mx_version": "7.55.5",
7+
"mx_version": "7.55.6",
88

99
"COMMENT.jdks": "When adding or removing JDKs keep in sync with JDKs in ci/common.jsonnet",
1010
"jdks": {

sdk/mx.sdk/mx_sdk_benchmark.py

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3029,11 +3029,29 @@ def validateStdoutWithDimensions(self, out, benchmarks, bmSuiteArgs, retcode=Non
30293029
def computeDerivedDatapoints(self, datapoints: DataPoints) -> DataPoints:
30303030
"""Adds derived datapoints to the list of datapoints captured from the benchmark stdout or generated files.
30313031
Adds datapoints such as:
3032+
* rss-distribution: copies of rss datapoints, naming more clearly indicates that the metric comprises the
3033+
distribution represented by percentile values
3034+
* latency-distribution: copies of latency datapoints, naming more clearly indicates that the metric comprises
3035+
the distribution represented by percentile values
30323036
* max-rss: copied from specific rss percentile values
30333037
* time-to-first-response: copied from response_time with iteration 0
30343038
* max-time: copied from response_time with the highest value
30353039
* ops-per-GB-second: computed as throughput divided by max-rss
30363040
"""
3041+
# rss-distribution
3042+
rss_dps = filter(lambda dp: dp["metric.name"] == "rss", datapoints)
3043+
for rss_dp in rss_dps:
3044+
rss_dp_copy = rss_dp.copy()
3045+
rss_dp_copy["metric.name"] = "rss-distribution"
3046+
datapoints.append(rss_dp_copy)
3047+
3048+
# latency-distribution
3049+
latency_dps = filter(lambda dp: dp["metric.name"] == "latency", datapoints)
3050+
for latency_dp in latency_dps:
3051+
latency_dp_copy = latency_dp.copy()
3052+
latency_dp_copy["metric.name"] = "latency-distribution"
3053+
datapoints.append(latency_dp_copy)
3054+
30373055
# max-rss
30383056
percentile_to_copy_into_max_rss = float(mx_benchmark.RssPercentilesTracker.MaxRssCopyRule.percentile_to_copy_into_max_rss)
30393057
rss_dp_to_copy_from = next(filter(lambda dp: dp["metric.name"] == "rss" and dp["metric.percentile"] == percentile_to_copy_into_max_rss, datapoints), None)

sdk/mx.sdk/suite.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
# SOFTWARE.
4040
#
4141
suite = {
42-
"mxversion": "7.55.2",
42+
"mxversion": "7.55.6",
4343
"name" : "sdk",
4444
"version" : "26.0.0",
4545
"release" : False,

0 commit comments

Comments
 (0)