Skip to content

Issue #11782 Updated IGV_DATA_SETTINGS file location to 'target/classes #12217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Issue #11782 Updated IGV_DATA_SETTINGS file location to 'target/classes #12217

wants to merge 0 commits into from

Conversation

dasarathirout
Copy link
Member

Issue #11782 Updated IGV_DATA_SETTINGS file location to 'target/classes/*'

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 23, 2025
@dasarathirout dasarathirout mentioned this pull request Sep 23, 2025
Closed
@oubidar-Abderrahim oubidar-Abderrahim added the igv Ideal Graph Visualizer label Sep 24, 2025
@oubidar-Abderrahim
Copy link
Member

Thank you for your contribution

@oubidar-Abderrahim
Copy link
Member

Hi @wirthi could you please review or assign someone to do so? thanks

@tkrodriguez
Copy link
Member

tkrodriguez commented Sep 24, 2025 •
edited
Loading

IGV_DATA_SETTINGS is actually dead after IGV_JSONEXPORTER was deleted in ba4c7acab9764c9371d9cf4a3785cd39480172dc so it should just be deleted from suite.py. github doesn't do a very good job with that diff because it's so big, but it's basically this in suite.py

@@ -122,17 +64,5 @@ suite = {
       },
       "defaultBuild" : False,
     },
-
-    "IGV_JSONEXPORTER": {
-      "dependencies" : [
-        "IdealGraphVisualizer",
-      ],
-      "distDependencies": [
-        "IGV_DATA_SETTINGS",
-        "OPENIDE_UTIL_LOOKUP",
-        "OPENIDE_UTIL",
-      ],
-      "defaultBuild" : False,
-    },
   },
 }

dasarathirout
dasarathirout commented Sep 24, 2025
View reviewed changes
visualizer/mx.visualizer/suite.py
],
},

"IGV_DATA_SETTINGS": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkrodriguez, Thanks for the suggestion, removed IGV_DATA_SETTINGS .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you squash this down to a single commit I'll push it from our side.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got new PR #12226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wirthi wirthi Awaiting requested review from wirthi

@dougxc dougxc Awaiting requested review from dougxc

@tkrodriguez tkrodriguez Awaiting requested review from tkrodriguez

Assignees
No one assigned
Labels
igv Ideal Graph Visualizer OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dasarathirout @oubidar-Abderrahim @tkrodriguez