[GR-68984] Fix the reachability-metadata schema and include it with GraalVM. #12255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
force-pushed
the
vj/GR-68984-ship-metadata-schema
branch
from
61838d7 to
016dfc2
Compare
graalvmbot
changed the title
graalvmbot
changed the title
graalvmbot
force-pushed
the
vj/GR-68984-ship-metadata-schema
branch
13 times, most recently
from
793c52d to
5f13ae8
Compare
|
@zakkak I have fixed all the issues I could find in the schema. Please have a look and see if you see any outstanding issues. |
zakkak
suggested changes
Oct 6, 2025
| "pattern": "^[^.;\\[/]+(\\.[^.;\\[/]+)*(\\[])*$" | ||
| }, | ||
| "reason": { | ||
| "title": "A reason(s) for including this element (e.g., needed for establishing connections, or needed by method X#Y for task Z)", |
There was a problem hiding this comment.
Suggested change
| "title": "A reason(s) for including this element (e.g., needed for establishing connections, or needed by method X#Y for task Z)", | |
| "title": "Reason(s) for including this element (e.g., needed for establishing connections, or needed by method X#Y for task Z)", |
| "default": {}, | ||
| "properties": { | ||
| "comment": { | ||
| "title": "A comment applying to the whole file (e.g., generation date, author, etc.)", |
There was a problem hiding this comment.
Suggested change
| "title": "A comment applying to the whole file (e.g., generation date, author, etc.)", | |
| "title": "Comment(s) applying to the whole file (e.g., generation date, author, etc.)", |
graalvmbot
force-pushed
the
vj/GR-68984-ship-metadata-schema
branch
4 times, most recently
from
82896c5 to
22f2123
Compare
|
@zakkak thanks for the comments, I have integrated all the fixes proposed. |
graalvmbot
force-pushed
the
vj/GR-68984-ship-metadata-schema
branch
2 times, most recently
from
3a943ec to
594004f
Compare
graalvmbot
force-pushed
the
vj/GR-68984-ship-metadata-schema
branch
from
594004f to
24c97ee
Compare
zakkak
added a commit
to zakkak/quarkus
that referenced
this pull request
Oct 7, 2025
The new `reachability-metadata.json` file doesn't allow the exclusion of resources and uses globs for the inclusion of them. See: * oracle/graal#7487 * oracle/graal#9048 * oracle/graal#12255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are the following:
bundles,jni,serialization. The idea is that this schema should drive users towards the current format, instead of allowing all past formats.fieldandreflectioninto the document. It is used once now."$ref": "config-condition-schema-v1.0.0.json",.To review this PR use: