Skip to content

[GR-70333] Don't use NumUtil in MinMaxCanonicalizationTest #12300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
+6 −3
Merged

[GR-70333] Don't use NumUtil in MinMaxCanonicalizationTest #12300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .../jdk.graal.compiler.test/src/jdk/graal/compiler/core/test/MinMaxCanonicalizationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@

import org.junit.Test;

import jdk.graal.compiler.core.common.NumUtil;
import jdk.graal.compiler.nodes.StructuredGraph;
import jdk.vm.ci.meta.ResolvedJavaMethod;

Expand Down Expand Up @@ -102,7 +101,9 @@ public void testByteMaxEqualsToLessThanSymbolic() {
}

public static boolean byteUMaxEqualsToLessThanSnippet(ByteHolder holder) {
return NumUtil.maxUnsigned(holder.b & 0xff, 7) == 7;
byte b = holder.b;
int result = Integer.compareUnsigned(b & 0xff, 7) < 0 ? 7 : b & 0xff;
return result == 7;
}

public static boolean byteUMaxEqualsToLessThanReference(ByteHolder holder) {
Expand All @@ -128,7 +129,9 @@ public void testByteMinEqualsToLessThan() {
}

public static boolean byteUMinEqualsToLessThanSnippet(ByteHolder holder) {
return NumUtil.minUnsigned(holder.b & 0xff, 7) == 7;
byte b = holder.b;
int result = Integer.compareUnsigned(b & 0xff, 7) > 0 ? 7 : b & 0xff;
return result == 7;
}

public static boolean byteUMinEqualsToLessThanReference(ByteHolder holder) {
Expand Down