Fix Groovy substitutions for Apache Groovy /5.x compatibility#12986
Draft
lissam1 wants to merge 1 commit intooracle:masterfrom
Draft
Fix Groovy substitutions for Apache Groovy /5.x compatibility#12986lissam1 wants to merge 1 commit intooracle:masterfrom
lissam1 wants to merge 1 commit intooracle:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Native Image builds fail when Apache Groovy 5.x is present on the classpath with the following error during the initialization phase:
This affects projects using:
org.apache.groovy:groovy)Reported in issue #10200.
Investigation & Root Cause
Through investigation of the Groovy source code and GraalVM substitution mechanism, we identified the following:
1. Architecture Change in Groovy 4.x/5.x
Groovy changes:
Old Groovy (2.x/3.x):
org.codehaus.groovy.vmplugin.v7.IndyInterfacecontainsinvalidateSwitchPoints()methodNew Groovy (4.x/5.x):
org.codehaus.groovy.vmplugin.v8.IndyInterfaceis the primary interface (containsinvalidateSwitchPoints())org.codehaus.groovy.vmplugin.v7.IndyInterfaceexists only as a deprecated bridge class for backward compatibilityinvalidateSwitchPoints()- it only delegates to v8Evidence from Groovy source code:
v7/IndyInterface (Groovy 5.x):
v8/IndyInterface (Groovy 5.x):
2. Current GraalVM Substitution Issue
The existing
GroovyIndyInterfaceFeaturehas :Only targets v7
Solution
This PR updates the Groovy substitutions to handle both v7 and v8:
Changes Made
isInConfiguration()to detect both v7 and v8 IndyInterface classesRelated Issues
Fixes #10200