[GR-73281] [GR-73404] Avoid redundant --add-modules arguments getting passed to the builder.#12989
Merged
graalvmbot merged 5 commits intomasterfrom Feb 17, 2026
Merged
[GR-73281] [GR-73404] Avoid redundant --add-modules arguments getting passed to the builder.#12989graalvmbot merged 5 commits intomasterfrom
graalvmbot merged 5 commits intomasterfrom
Conversation
… for java.base packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of GR-49845 introduced an issue with adding more
--add-modulesarguments to the builder then what we actually need. This should be fixed so that understanding the--add-modulesarguments that are getting passed to the builder is easier.To test this
native-image-module-testsis extended to depend on modulejdk.dynalink.Without the fix implemented here the builder VM would get
Out of those modules only the
jdk.dynalinkis needed because the other modules are dependencies that the builder itself already requires. With the fix we now only have--add-modules=jdk.dynalinkadded to the builder args.A positive side effect of this cleanup is that the number of calls to
NativeImageClassLoaderSupport.LoadClassHandler#initModuleis greatly reduced.