New operator should not forget to evaluate arguments.

Author: iamstolis

graal-js/src/com.oracle.truffle.js.test/js/EvaluateNew.js

@@ -0,0 +1,40 @@
+/*
+ * Copyright (c) 2020, 2020, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * Licensed under the Universal Permissive License v 1.0 as shown at http://oss.oracle.com/licenses/upl.
+ */
+
+/**
+ * Tests of the evaluation of 'new' operator.
+ * 
+ * @option nashorn-compat
+ */
+
+load('assert.js');
+
+(function missingClassArgumentsEvaluated() {
+    var constructor = java.ThisClassDoesNotExist;
+
+    assertFail(function() {
+        new constructor(constructor = Object);
+    });
+
+    assertSame(Object, constructor);
+})();
+
+(function jsAdapterArgumentsEvaluated() {
+    var constructor = new JSAdapter({});
+
+    try {
+        new constructor(constructor = Object);
+    } catch (e) {
+        // GraalJS does not throw but Nashorn throws java.lang.invoke.WrongMethodTypeException: Parameter counts differ.
+        // This test checks the evaluation of arguments which should be performed no matter if this kind of error is thrown or not
+        // => this test does not care whether the error is thrown.
+    }
+
+    assertSame(Object, constructor);
+})();
+
+true;

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/nodes/function/JSNewNode.java

@@ -157,9 +157,9 @@ public Object doNewReturnThis(VirtualFrame frame, DynamicObject target) {
 
     @Specialization(guards = "isJSAdapter(target)")
     public Object doJSAdapter(VirtualFrame frame, DynamicObject target) {
+        Object[] args = getAbstractFunctionArguments(frame);
         Object newFunction = JSObject.get(JSAdapter.getAdaptee(target), JSAdapter.NEW);
         if (JSFunction.isJSFunction(newFunction)) {
-            Object[] args = getAbstractFunctionArguments(frame);
             return JSFunction.call((DynamicObject) newFunction, target, args);
         } else {
             return Undefined.instance;
@@ -197,9 +197,9 @@ protected Object doNewJSProxy(VirtualFrame frame, DynamicObject proxy) {
         return result;
     }
 
-    @TruffleBoundary
     @Specialization(guards = "isJavaPackage(target)")
-    public Object createClassNotFoundError(DynamicObject target) {
+    public Object createClassNotFoundError(VirtualFrame frame, DynamicObject target) {
+        getAbstractFunctionArguments(frame);
         throw Errors.createTypeErrorClassNotFound(JavaPackage.getPackageName(target));
     }
 
@@ -253,9 +253,14 @@ private Object extend(Class<?> type, TruffleLanguage.Env env) {
         return env.asHostSymbol(adapterClass);
     }
 
-    @TruffleBoundary
     @Specialization(guards = {"!isJSFunction(target)", "!isJSAdapter(target)", "!isProxy(target)", "!isJavaPackage(target)", "!isForeignObject(target)"})
-    public Object createFunctionTypeError(Object target) {
+    public Object createFunctionTypeError(VirtualFrame frame, Object target) {
+        getAbstractFunctionArguments(frame);
+        return throwFunctionTypeError(target);
+    }
+
+    @TruffleBoundary
+    private Object throwFunctionTypeError(Object target) {
         String targetStr = getTarget().expressionToString();
         Object targetForError = targetStr == null ? target : targetStr;
         if (context.isOptionNashornCompatibilityMode()) {

graal-js/test/test262.json

@@ -1697,14 +1697,6 @@
     "filePath" : "language/expressions/dynamic-import/usage-from-eval.js",
     "status" : "FAIL",
     "comment" : "TODO: evaluate (Test262 tests update 2018-10-29)"
-  }, {
-    "filePath" : "language/expressions/new/ctorExpr-isCtor-after-args-eval-fn-wrapup.js",
-    "status" : "FAIL",
-    "comment" : "new failures update 2020-04-01"
-  }, {
-    "filePath" : "language/expressions/new/ctorExpr-isCtor-after-args-eval.js",
-    "status" : "FAIL",
-    "comment" : "new failures update 2020-04-01"
   }, {
     "filePath" : "language/statements/class/accessor-name-inst-computed-yield-expr.js",
     "status" : "FAIL",