Skip to content

Commit 11b90ef

Browse files
fangererfangerer
committed
[GR-18189] Use ReferenceLibrary and cleanup IsSameTypeNode implementation.
PullRequest: graalpython/653
2 parents 3e069f9 + 902822c commit 11b90ef

File tree

28 files changed

+135
-191
lines changed

28 files changed

+135
-191
lines changed

‎graalpython/com.oracle.graal.python.test/src/tests/cpyext/test_misc.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -180,9 +180,9 @@ def compile_module(self, name):
180180
lambda: (
181181
(True, lambda arg0, *args: arg0),
182182
(False, lambda arg0, *args: arg0),
183-
# Fix this! GR-18423
184-
# (10, lambda arg0, *args: arg0),
185-
# (10.0, lambda arg0, *args: arg0),
183+
(10, lambda arg0, *args: arg0),
184+
(10.0, lambda arg0, *args: arg0),
185+
(float('nan'), lambda arg0, *args: arg0),
186186
("ten", lambda arg0, *args: arg0),
187187
),
188188
code="""PyObject* PointerEquality_Primitive(PyObject* pyVal, PyObject* fun) {

‎graalpython/com.oracle.graal.python.test/testData/goldenFiles/AwaitAndAsyncTests/asyncWith01.tast

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,11 @@ ModuleRootNode Name: <module 'asyncWith01'> SourceSection: [0,34]`async def f():
4040
Value: 1
4141
LookupInheritedAttributeNode SourceSection: None
4242
LookupAttributeInMRONodeGen SourceSection: None
43-
IsSameTypeSlowNodeGen SourceSection: None
43+
IsSameTypeNodeGen SourceSection: None
4444
GetLazyClassNodeGen SourceSection: None
4545
LookupInheritedAttributeNode SourceSection: None
4646
LookupAttributeInMRONodeGen SourceSection: None
47-
IsSameTypeSlowNodeGen SourceSection: None
47+
IsSameTypeNodeGen SourceSection: None
4848
GetLazyClassNodeGen SourceSection: None
4949
CachedCallNodeGen SourceSection: None
5050
CreateArgumentsNodeGen SourceSection: None

‎graalpython/com.oracle.graal.python.test/testData/goldenFiles/AwaitAndAsyncTests/asyncWith02.tast

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,11 @@ ModuleRootNode Name: <module 'asyncWith02'> SourceSection: [0,47]`async def f():
4646
ReadAttributeFromObjectNotTypeNodeGen SourceSection: None
4747
LookupInheritedAttributeNode SourceSection: None
4848
LookupAttributeInMRONodeGen SourceSection: None
49-
IsSameTypeSlowNodeGen SourceSection: None
49+
IsSameTypeNodeGen SourceSection: None
5050
GetLazyClassNodeGen SourceSection: None
5151
LookupInheritedAttributeNode SourceSection: None
5252
LookupAttributeInMRONodeGen SourceSection: None
53-
IsSameTypeSlowNodeGen SourceSection: None
53+
IsSameTypeNodeGen SourceSection: None
5454
GetLazyClassNodeGen SourceSection: None
5555
CachedCallNodeGen SourceSection: None
5656
CreateArgumentsNodeGen SourceSection: None
@@ -70,11 +70,11 @@ ModuleRootNode Name: <module 'asyncWith02'> SourceSection: [0,47]`async def f():
7070
ReadAttributeFromObjectNotTypeNodeGen SourceSection: None
7171
LookupInheritedAttributeNode SourceSection: None
7272
LookupAttributeInMRONodeGen SourceSection: None
73-
IsSameTypeSlowNodeGen SourceSection: None
73+
IsSameTypeNodeGen SourceSection: None
7474
GetLazyClassNodeGen SourceSection: None
7575
LookupInheritedAttributeNode SourceSection: None
7676
LookupAttributeInMRONodeGen SourceSection: None
77-
IsSameTypeSlowNodeGen SourceSection: None
77+
IsSameTypeNodeGen SourceSection: None
7878
GetLazyClassNodeGen SourceSection: None
7979
CachedCallNodeGen SourceSection: None
8080
CreateArgumentsNodeGen SourceSection: None

‎graalpython/com.oracle.graal.python.test/testData/goldenFiles/BasicTests/with01.tast

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ ModuleRootNode Name: <module 'with01'> SourceSection: [0,21]`with A() as a:↵
2222
Identifier: A
2323
LookupInheritedAttributeNode SourceSection: None
2424
LookupAttributeInMRONodeGen SourceSection: None
25-
IsSameTypeSlowNodeGen SourceSection: None
25+
IsSameTypeNodeGen SourceSection: None
2626
GetLazyClassNodeGen SourceSection: None
2727
LookupInheritedAttributeNode SourceSection: None
2828
LookupAttributeInMRONodeGen SourceSection: None
29-
IsSameTypeSlowNodeGen SourceSection: None
29+
IsSameTypeNodeGen SourceSection: None
3030
GetLazyClassNodeGen SourceSection: None
3131
CachedCallNodeGen SourceSection: None
3232
CreateArgumentsNodeGen SourceSection: None

‎graalpython/com.oracle.graal.python.test/testData/goldenFiles/BasicTests/with02.tast

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@ ModuleRootNode Name: <module 'with02'> SourceSection: [0,31]`with A() as a, B()
2323
Identifier: B
2424
LookupInheritedAttributeNode SourceSection: None
2525
LookupAttributeInMRONodeGen SourceSection: None
26-
IsSameTypeSlowNodeGen SourceSection: None
26+
IsSameTypeNodeGen SourceSection: None
2727
GetLazyClassNodeGen SourceSection: None
2828
LookupInheritedAttributeNode SourceSection: None
2929
LookupAttributeInMRONodeGen SourceSection: None
30-
IsSameTypeSlowNodeGen SourceSection: None
30+
IsSameTypeNodeGen SourceSection: None
3131
GetLazyClassNodeGen SourceSection: None
3232
CachedCallNodeGen SourceSection: None
3333
CreateArgumentsNodeGen SourceSection: None
@@ -48,11 +48,11 @@ ModuleRootNode Name: <module 'with02'> SourceSection: [0,31]`with A() as a, B()
4848
Identifier: A
4949
LookupInheritedAttributeNode SourceSection: None
5050
LookupAttributeInMRONodeGen SourceSection: None
51-
IsSameTypeSlowNodeGen SourceSection: None
51+
IsSameTypeNodeGen SourceSection: None
5252
GetLazyClassNodeGen SourceSection: None
5353
LookupInheritedAttributeNode SourceSection: None
5454
LookupAttributeInMRONodeGen SourceSection: None
55-
IsSameTypeSlowNodeGen SourceSection: None
55+
IsSameTypeNodeGen SourceSection: None
5656
GetLazyClassNodeGen SourceSection: None
5757
CachedCallNodeGen SourceSection: None
5858
CreateArgumentsNodeGen SourceSection: None

‎graalpython/com.oracle.graal.python.test/testData/goldenFiles/BasicTests/with03.tast

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,11 @@ ModuleRootNode Name: <module 'with03'> SourceSection: [0,35]`def fn():↵ with
4949
ReadAttributeFromObjectNotTypeNodeGen SourceSection: None
5050
LookupInheritedAttributeNode SourceSection: None
5151
LookupAttributeInMRONodeGen SourceSection: None
52-
IsSameTypeSlowNodeGen SourceSection: None
52+
IsSameTypeNodeGen SourceSection: None
5353
GetLazyClassNodeGen SourceSection: None
5454
LookupInheritedAttributeNode SourceSection: None
5555
LookupAttributeInMRONodeGen SourceSection: None
56-
IsSameTypeSlowNodeGen SourceSection: None
56+
IsSameTypeNodeGen SourceSection: None
5757
GetLazyClassNodeGen SourceSection: None
5858
CachedCallNodeGen SourceSection: None
5959
CreateArgumentsNodeGen SourceSection: None

‎graalpython/com.oracle.graal.python.test/testData/goldenFiles/BasicTests/with04.tast

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,11 @@ ModuleRootNode Name: <module 'with04'> SourceSection: [0,45]`def fn():↵ with
5050
ReadAttributeFromObjectNotTypeNodeGen SourceSection: None
5151
LookupInheritedAttributeNode SourceSection: None
5252
LookupAttributeInMRONodeGen SourceSection: None
53-
IsSameTypeSlowNodeGen SourceSection: None
53+
IsSameTypeNodeGen SourceSection: None
5454
GetLazyClassNodeGen SourceSection: None
5555
LookupInheritedAttributeNode SourceSection: None
5656
LookupAttributeInMRONodeGen SourceSection: None
57-
IsSameTypeSlowNodeGen SourceSection: None
57+
IsSameTypeNodeGen SourceSection: None
5858
GetLazyClassNodeGen SourceSection: None
5959
CachedCallNodeGen SourceSection: None
6060
CreateArgumentsNodeGen SourceSection: None
@@ -78,11 +78,11 @@ ModuleRootNode Name: <module 'with04'> SourceSection: [0,45]`def fn():↵ with
7878
ReadAttributeFromObjectNotTypeNodeGen SourceSection: None
7979
LookupInheritedAttributeNode SourceSection: None
8080
LookupAttributeInMRONodeGen SourceSection: None
81-
IsSameTypeSlowNodeGen SourceSection: None
81+
IsSameTypeNodeGen SourceSection: None
8282
GetLazyClassNodeGen SourceSection: None
8383
LookupInheritedAttributeNode SourceSection: None
8484
LookupAttributeInMRONodeGen SourceSection: None
85-
IsSameTypeSlowNodeGen SourceSection: None
85+
IsSameTypeNodeGen SourceSection: None
8686
GetLazyClassNodeGen SourceSection: None
8787
CachedCallNodeGen SourceSection: None
8888
CreateArgumentsNodeGen SourceSection: None

‎graalpython/com.oracle.graal.python.test/testData/goldenFiles/BasicTests/with05.tast

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,11 @@ ModuleRootNode Name: <module 'with05'> SourceSection: [0,36]`def fn():↵ with
4646
ReadAttributeFromObjectNotTypeNodeGen SourceSection: None
4747
LookupInheritedAttributeNode SourceSection: None
4848
LookupAttributeInMRONodeGen SourceSection: None
49-
IsSameTypeSlowNodeGen SourceSection: None
49+
IsSameTypeNodeGen SourceSection: None
5050
GetLazyClassNodeGen SourceSection: None
5151
LookupInheritedAttributeNode SourceSection: None
5252
LookupAttributeInMRONodeGen SourceSection: None
53-
IsSameTypeSlowNodeGen SourceSection: None
53+
IsSameTypeNodeGen SourceSection: None
5454
GetLazyClassNodeGen SourceSection: None
5555
CachedCallNodeGen SourceSection: None
5656
CreateArgumentsNodeGen SourceSection: None

‎graalpython/com.oracle.graal.python.test/testData/goldenFiles/BasicTests/with06.tast

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,11 @@ ModuleRootNode Name: <module 'with06'> SourceSection: [0,56]`def fn():↵ with
5050
ReadAttributeFromObjectNotTypeNodeGen SourceSection: None
5151
LookupInheritedAttributeNode SourceSection: None
5252
LookupAttributeInMRONodeGen SourceSection: None
53-
IsSameTypeSlowNodeGen SourceSection: None
53+
IsSameTypeNodeGen SourceSection: None
5454
GetLazyClassNodeGen SourceSection: None
5555
LookupInheritedAttributeNode SourceSection: None
5656
LookupAttributeInMRONodeGen SourceSection: None
57-
IsSameTypeSlowNodeGen SourceSection: None
57+
IsSameTypeNodeGen SourceSection: None
5858
GetLazyClassNodeGen SourceSection: None
5959
CachedCallNodeGen SourceSection: None
6060
CreateArgumentsNodeGen SourceSection: None
@@ -78,11 +78,11 @@ ModuleRootNode Name: <module 'with06'> SourceSection: [0,56]`def fn():↵ with
7878
ReadAttributeFromObjectNotTypeNodeGen SourceSection: None
7979
LookupInheritedAttributeNode SourceSection: None
8080
LookupAttributeInMRONodeGen SourceSection: None
81-
IsSameTypeSlowNodeGen SourceSection: None
81+
IsSameTypeNodeGen SourceSection: None
8282
GetLazyClassNodeGen SourceSection: None
8383
LookupInheritedAttributeNode SourceSection: None
8484
LookupAttributeInMRONodeGen SourceSection: None
85-
IsSameTypeSlowNodeGen SourceSection: None
85+
IsSameTypeNodeGen SourceSection: None
8686
GetLazyClassNodeGen SourceSection: None
8787
CachedCallNodeGen SourceSection: None
8888
CreateArgumentsNodeGen SourceSection: None

‎graalpython/com.oracle.graal.python.test/testData/goldenFiles/GeneratorAndCompForTests/generator10.tast

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,11 +98,11 @@ ModuleRootNode Name: <module 'generator10'> SourceSection: [0,155]`def non_empty
9898
ReadAttributeFromObjectNotTypeNodeGen SourceSection: None
9999
LookupInheritedAttributeNode SourceSection: None
100100
LookupAttributeInMRONodeGen SourceSection: None
101-
IsSameTypeSlowNodeGen SourceSection: None
101+
IsSameTypeNodeGen SourceSection: None
102102
GetLazyClassNodeGen SourceSection: None
103103
LookupInheritedAttributeNode SourceSection: None
104104
LookupAttributeInMRONodeGen SourceSection: None
105-
IsSameTypeSlowNodeGen SourceSection: None
105+
IsSameTypeNodeGen SourceSection: None
106106
GetLazyClassNodeGen SourceSection: None
107107
CachedCallNodeGen SourceSection: None
108108
CreateArgumentsNodeGen SourceSection: None

0 commit comments

Comments
 (0)