Fix no default handling in JavaDoubleConversionNode

msimacek · msimacek · commit 8b00b658646a · 2021-05-11T11:23:42.000+02:00
diff --git a/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/function/builtins/clinic/JavaDoubleConversionNode.java b/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/function/builtins/clinic/JavaDoubleConversionNode.java
@@ -93,6 +93,12 @@ public static JavaDoubleConversionNode create(@DefaultValue double defaultValue,
         return JavaDoubleConversionNodeGen.create(defaultValue, useDefaultForNone);
     }
 
+    @ClinicConverterFactory(shortCircuitPrimitive = PrimitiveType.Double)
+    public static JavaDoubleConversionNode create(@UseDefaultForNone boolean useDefaultForNone) {
+        assert !useDefaultForNone : "defaultValue must be provided if useDefaultForNone is true";
+        return JavaDoubleConversionNodeGen.create(0.0, false);
+    }
+
     protected boolean isHandledPNone(Object value) {
         return isHandledPNone(useDefaultForNone, value);
     }

Original file line number	Diff line number	Diff line change
`@@ -93,6 +93,12 @@ public static JavaDoubleConversionNode create(@DefaultValue double defaultValue,`
`93`	`93`	`return JavaDoubleConversionNodeGen.create(defaultValue, useDefaultForNone);`
`94`	`94`	`}`
`95`	`95`
	`96`	`+ @ClinicConverterFactory(shortCircuitPrimitive = PrimitiveType.Double)`
	`97`	`+ public static JavaDoubleConversionNode create(@UseDefaultForNone boolean useDefaultForNone) {`
	`98`	`+ assert !useDefaultForNone : "defaultValue must be provided if useDefaultForNone is true";`
	`99`	`+ return JavaDoubleConversionNodeGen.create(0.0, false);`
	`100`	`+ }`
	`101`	`+`
`96`	`102`	`protected boolean isHandledPNone(Object value) {`
`97`	`103`	`return isHandledPNone(useDefaultForNone, value);`
`98`	`104`	`}`