Fix cert serial number padding

msimacek · msimacek · commit a8bb1c5af319 · 2021-03-03T18:40:21.000+01:00
diff --git a/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/ssl/CertUtils.java b/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/ssl/CertUtils.java
@@ -192,7 +192,8 @@ private static HashingStorage setItem(HashingStorageLibrary hlib, HashingStorage
     @TruffleBoundary
     private static String getSerialNumber(X509Certificate x509Certificate) {
         String sn = x509Certificate.getSerialNumber().toString(16).toUpperCase();
-        return sn.length() == 1 ? "0" + sn : sn;
+        // i2a_ASN1_INTEGER pads the number to have even number of digits
+        return sn.length() % 2 == 0 ? sn : '0' + sn;
     }
 
     @TruffleBoundary

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,8 @@ private static HashingStorage setItem(HashingStorageLibrary hlib, HashingStorage`
`192`	`192`	`@TruffleBoundary`
`193`	`193`	`private static String getSerialNumber(X509Certificate x509Certificate) {`
`194`	`194`	`String sn = x509Certificate.getSerialNumber().toString(16).toUpperCase();`
`195`		`- return sn.length() == 1 ? "0" + sn : sn;`
	`195`	`+ // i2a_ASN1_INTEGER pads the number to have even number of digits`
	`196`	`+ return sn.length() % 2 == 0 ? sn : '0' + sn;`
`196`	`197`	`}`
`197`	`198`
`198`	`199`	`@TruffleBoundary`