Reuse ErrorCallback to report warnings from parser

Author: otethal

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/PythonLanguage.java

@@ -526,7 +526,7 @@ public RootCallTarget parseForBytecodeInterpreter(PythonContext context, Source
             Parser parser = Compiler.createParser(source.getCharacters().toString(), errorCb, type, interactiveTerminal);
             ModTy mod = (ModTy) parser.parse();
             assert mod != null;
-            return compileForBytecodeInterpreter(context, mod, source, topLevel, optimize, argumentNames);
+            return compileForBytecodeInterpreter(context, mod, source, topLevel, optimize, argumentNames, errorCb);
         } catch (PException e) {
             if (topLevel) {
                 PythonUtils.getOrCreateCallTarget(new TopLevelExceptionHandler(this, e)).call();
@@ -536,8 +536,12 @@ public RootCallTarget parseForBytecodeInterpreter(PythonContext context, Source
     }
 
     @TruffleBoundary
-    public RootCallTarget compileForBytecodeInterpreter(PythonContext context, ModTy mod, Source source, boolean topLevel, int optimize, List<String> argumentNames) {
-        RaisePythonExceptionErrorCallback errorCb = new RaisePythonExceptionErrorCallback(source, PythonOptions.isPExceptionWithJavaStacktrace(this));
+    public RootCallTarget compileForBytecodeInterpreter(PythonContext context, ModTy mod, Source source, boolean topLevel, int optimize, List<String> argumentNames,
+                    RaisePythonExceptionErrorCallback errorCallback) {
+        RaisePythonExceptionErrorCallback errorCb = errorCallback;
+        if (errorCb == null) {
+            errorCb = new RaisePythonExceptionErrorCallback(source, PythonOptions.isPExceptionWithJavaStacktrace(this));
+        }
         try {
             Compiler compiler = new Compiler(errorCb);
             boolean hasArguments = argumentNames != null && !argumentNames.isEmpty();
@@ -547,9 +551,9 @@ public RootCallTarget compileForBytecodeInterpreter(PythonContext context, ModTy
             CompilationUnit cu = compiler.compile(mod, EnumSet.noneOf(Compiler.Flags.class), optimize);
             CodeUnit co = cu.assemble();
             RootNode rootNode = PBytecodeRootNode.create(this, co, source, errorCb);
-            GilNode gil = GilNode.getUncached();
-            boolean wasAcquired = gil.acquire(context, rootNode);
             if (topLevel) {
+                GilNode gil = GilNode.getUncached();
+                boolean wasAcquired = gil.acquire(context, rootNode);
                 try {
                     errorCb.triggerDeprecationWarnings();
                 } finally {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/BuiltinFunctions.java

@@ -1124,6 +1124,7 @@ Object compile(TruffleString expression, TruffleString filename, TruffleString m
                 RaisePythonExceptionErrorCallback errorCb = new RaisePythonExceptionErrorCallback(source, PythonOptions.isPExceptionWithJavaStacktrace(getLanguage()));
                 Parser parser = Compiler.createParser(code.toJavaStringUncached(), errorCb, type, false);
                 ModTy mod = (ModTy) parser.parse();
+                errorCb.triggerDeprecationWarnings();
                 return AstModuleBuiltins.sst2Obj(getContext(), mod);
             }
             CallTarget ct;
@@ -1211,7 +1212,7 @@ Object generic(VirtualFrame frame, Object wSource, Object wFilename, Object wMod
                 ModTy mod = AstModuleBuiltins.obj2sst(getContext(), wSource);
                 // TODO _PyAST_Validate
                 Source source = createFakeSource();
-                RootCallTarget rootCallTarget = getLanguage().compileForBytecodeInterpreter(getContext(), mod, source, false, optimize, null);
+                RootCallTarget rootCallTarget = getLanguage().compileForBytecodeInterpreter(getContext(), mod, source, false, optimize, null, null);
                 return wrapRootCallTarget(rootCallTarget);
             }
             TruffleString source = sourceAsString(frame, wSource, filename, interopLib, acquireLib, bufferLib, handleDecodingErrorNode, asStrNode, switchEncodingNode);