[JVSC-253] Refactor Netbeans localisation build #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Achal1607
reviewed
Sep 23, 2024
sid-srini
force-pushed
the
nb-l10n-remove-disabled-modules
branch
from
0a5d3b4 to
376557c
Compare
naren2605
reviewed
Sep 23, 2024
naren2605
approved these changes
Sep 23, 2024
1. Moved the addition of the build project dirs locale_ja and locale_zh_CN to nbcode/l10n/ from inside netbeans-l10n/.
- This is because the netbeans-l10n repo provides the build projects locale_de/ and locale_cs/ only as samples.
- Thus the repo would not need to accept more such samples causing bloat.
- Only the addition of localised messages for the java.lsp.server module is included in the patch.
- This slimmed and renamed patch maybe submitted to the repo as a PR.
2. Enhanced the Package ant task definition in netbeans-l10n to:
- Support accepting "disabledModules" and "enabledClusterPath" as input.
- These are used to filter unneeded clusters and modules from being built.
- The platform properties "disabled.modules" and "cluster.path" can be used to set these parameters.
- The former is expected to contain comma-separated module names.
- The latter is expected to contain path-delimiter separated cluster paths.
- This is stored in patches/l10n/filter-enabled-clusters-disabled-modules-code-cleanup.diff
3. Fixed nbcode/nbproject/platform.properties to specify ${path.separator} instead of ':' for the cluster.path value separator.
- This is needed for build support on windows.
4. Loaded the platform.properties in the locale build scripts and pass the values for "disabled.modules" and "cluster.path" to the buildPackage task.
5. Updated the build.xml scripts to pass the appropriate property values for the netbeans/ and netbeans-l10n/ dirs.
6. Fixed the clean-l10n target to clean out the copied artifacts from vscode/nbcode/extras/
7. Fixed minor typos.
8. Changed javac source 1.8 -> release 17
Signed-off-by: Siddharth Srinivasan <[email protected]>
sid-srini
force-pushed
the
nb-l10n-remove-disabled-modules
branch
from
376557c to
40c9754
Compare
Achal1607
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the addition of the build project dirs locale_ja and locale_zh_CN to nbcode/l10n/ from inside netbeans-l10n/.
Enhanced the Package ant task definition in netbeans-l10n to:
disabledModulesandenabledClusterPathas input.disabled.modulesandcluster.pathcan be used to set these parameters.Fixed nbcode/nbproject/platform.properties to specify
${path.separator}instead of':'for thecluster.pathvalue separator.Loaded the platform.properties in the locale build scripts and pass the values for
disabled.modulesandcluster.pathto the buildPackage task.Updated the build.xml scripts to pass the appropriate property values for the netbeans/ and netbeans-l10n/ dirs.
Fixed the
clean-l10ntarget to clean out the copied artifacts from vscode/nbcode/extras/Fixed minor typos.
Changed javac source 1.8 -> release 17