JVSC #217 | fixing test runner incorrectly processes test names #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
naren2605
force-pushed
the
fix-217
branch
3 times, most recently
from
72f76ff to
77b4ec0
Compare
sid-srini
requested changes
Oct 29, 2024
Member
sid-srini
left a comment
sid-srini
left a comment
There was a problem hiding this comment.
Thanks @naren2605 for fixing this so quickly.
Please check my comments on reducing the scope of the PR changes to the required changes only. Thanks.
sid-srini
approved these changes
Oct 29, 2024
Member
sid-srini
left a comment
sid-srini
left a comment
There was a problem hiding this comment.
This is very useful, especially for your added fix on the test controller creation. 👍 Thank you very much @naren2605.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix related details mentioned here #217 (comment)
sample test run after fixing the issue: