Skip to content

Fixed broken debugger attach UI options #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Fixed broken debugger attach UI options #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion vscode/src/commands/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ export const extCommands = {
startupCondition: appendPrefixToCommand('startup.condition'),
nbEventListener: appendPrefixToCommand('addEventListener'),
selectEditorProjs: appendPrefixToCommand('select.editor.projects'),
attachDebugger: appendPrefixToCommand("java.attachDebugger.connector"),
attachDebuggerConnector: appendPrefixToCommand("java.attachDebugger.connector"),
attachDebuggerConfigurations: appendPrefixToCommand("java.attachDebugger.configurations"),
loadWorkspaceTests: appendPrefixToCommand("load.workspace.tests"),
projectDeleteEntry: appendPrefixToCommand("foundProjects.deleteEntry")
}
Expand Down
4 changes: 2 additions & 2 deletions vscode/src/debugger/debugger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ class NetBeansConfigurationDynamicProvider implements vscode.DebugConfigurationP
return [];
}
let result: vscode.DebugConfiguration[] = [];
const attachConnectors: DebugConnector[] | null | undefined = await vscode.commands.executeCommand(extCommands.attachDebugger);
const attachConnectors: DebugConnector[] | null | undefined = await vscode.commands.executeCommand(extCommands.attachDebuggerConfigurations);
if (attachConnectors) {
for (let ac of attachConnectors) {
const debugConfig: vscode.DebugConfiguration = {
Expand All @@ -163,7 +163,7 @@ class NetBeansConfigurationDynamicProvider implements vscode.DebugConfigurationP
let defaultValue: string = ac.defaultValues[i];
if (!defaultValue.startsWith("${command:")) {
// Create a command that asks for the argument value:
let cmd: string = `${extCommands.attachDebugger}.${ac.id}.${ac.arguments[i]}`;
let cmd: string = `${extCommands.attachDebuggerConnector}.${ac.id}.${ac.arguments[i]}`;
debugConfig[ac.arguments[i]] = "${command:" + cmd + "}";
if (!commandValues.has(cmd)) {
commandValues.set(cmd, ac.defaultValues[i]);
Expand Down