Updated the JavaLangFeatures feature name extractor to work with JDK25+ EA #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
lahodaj
previously approved these changes
Aug 21, 2025
Achal1607
reviewed
Aug 22, 2025
There was a problem hiding this comment.
Shouldn't it be fragmentCode.length(), current would cutoff the last char?
or
something like this
prefix = fragmentKey.substring(0, fragmentKey.length() - fragmentCode.length());
There was a problem hiding this comment.
Thanks a lot. I've addressed this blooper. Please re-review. Thanks.
There was a problem hiding this comment.
instead of ignoring, should we log using fine or finer level, so that for debugging purpose it will help?
There was a problem hiding this comment.
instead of ignoring, should we log using fine or finer level, so that for debugging purpose it will help?
…5+ EA Updated the code to obtain the parent diagnostics keys for feature-related errors/warnings to be agnostic to movement across different diagnostic types in different JDKs. For example, Warning -> LinterWarning
sid-srini
force-pushed
the
tele-javaFeature-jdk25ea
branch
from
a237ecb to
594cda5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the code to obtain the parent diagnostics keys for feature-related errors/warnings to be agnostic to movement across different diagnostic types in different JDKs.
For example, Warning -> LinterWarning