Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
patches/8460-draft.diff
patches/8470.diff
patches/8484.diff
patches/8745-draft.diff
patches/disable-error-notification.diff
patches/mvn-sh.diff
patches/project-marker-jdk.diff
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,8 @@
*/
@ServiceProvider(service = JavaPlatformProvider.class, position = 10_000)
public class LspJavaPlatformProviderOverride extends AbstractJavaPlatformProviderOverride {

public LspJavaPlatformProviderOverride() {
super(System.getProperty("netbeans.lsp.java.platform.override", null)); //NOI18N
}
}
19 changes: 19 additions & 0 deletions patches/8745-draft.diff
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
diff --git a/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/ui/AbstractJavaPlatformProviderOverride.java b/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/ui/AbstractJavaPlatformProviderOverride.java
index df668954dd..054f85d0e5 100644
--- a/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/ui/AbstractJavaPlatformProviderOverride.java
+++ b/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/ui/AbstractJavaPlatformProviderOverride.java
@@ -39,6 +39,14 @@ public abstract class AbstractJavaPlatformProviderOverride implements JavaPlatfo
private final PropertyChangeSupport pcs = new PropertyChangeSupport(this);
private FileObject defaultPlatformOverride;

+ public AbstractJavaPlatformProviderOverride() {
+ this(null);
+ }
+
+ protected AbstractJavaPlatformProviderOverride(String defaultPlatformOverride) {
+ this.defaultPlatformOverride = defaultPlatformOverride == null ? null : FileUtil.toFileObject(new File(defaultPlatformOverride));
+ }
+
@Override
@SuppressWarnings("ReturnOfCollectionOrArrayField")
public JavaPlatform[] getInstalledPlatforms() {
4 changes: 4 additions & 0 deletions vscode/src/configurations/handlers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ export const jdkHomeValueHandler = (): string | null => {
null;
}

export const projectJdkHomeValueHandler = (): string | null => {
return getConfigurationValue(configKeys.projectJdkHome, null);
}

export const projectSearchRootsValueHandler = (): string => {
let projectSearchRoots: string = '';
const isProjectFolderSearchLimited: boolean = !getConfigurationValue(configKeys.disableProjSearchLimit, false);
Expand Down
6 changes: 5 additions & 1 deletion vscode/src/lsp/launchOptions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
limitations under the License.
*/
import { builtInConfigKeys, configKeys } from "../configurations/configuration"
import { isDarkColorThemeHandler, isNetbeansVerboseEnabled, jdkHomeValueHandler, lspServerVmOptionsHandler, projectSearchRootsValueHandler, userdirHandler } from "../configurations/handlers";
import { isDarkColorThemeHandler, isNetbeansVerboseEnabled, jdkHomeValueHandler, projectJdkHomeValueHandler, lspServerVmOptionsHandler, projectSearchRootsValueHandler, userdirHandler } from "../configurations/handlers";
import { l10n } from "../localiser";
import { isString } from "../utils";
import { userDefinedLaunchOptionsType } from "./types"
Expand All @@ -25,6 +25,10 @@ export const getUserConfigLaunchOptionsDefaults = (): userDefinedLaunchOptionsTy
value: jdkHomeValueHandler(),
optionToPass: ['--jdkhome']
},
[configKeys.projectJdkHome]: {
value: projectJdkHomeValueHandler(),
optionToPass: '-J-Dnetbeans.lsp.java.platform.override='
},
[configKeys.userdir]: {
value: userdirHandler(),
optionToPass: ['--userdir']
Expand Down