Skip to content

Fix parameter field buttons in Change Method Parameters UI in Language Server #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

Fix parameter field buttons in Change Method Parameters UI in Language Server #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
patches/7610.diff
patches/8038-draft.diff
patches/8690.diff
patches/8829.diff
patches/7893-draft.diff
patches/8460-draft.diff
patches/8745-draft.diff
Expand Down
46 changes: 46 additions & 0 deletions patches/8829.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
diff --git a/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/refactoring/ui/ChangeMethodParameters.html b/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/refactoring/ui/ChangeMethodParameters.html
index 57d4508acee0..0f289cb1485f 100644
--- a/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/refactoring/ui/ChangeMethodParameters.html
+++ b/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/refactoring/ui/ChangeMethodParameters.html
@@ -63,7 +63,7 @@
</div>
</div>
<div class="add-param flex">
- <button id="addParam" class="silent-button codicon codicon-add full-width flex-grow" data-bind="click: addParameter"><span class="button-text vscode-font">Add Parameter</span></button>
+ <button id="addParam" class="silent-button codicon codicon-add full-width flex-grow" data-bind="click: addParameter"><span class="button-text vscode-font"> Add Parameter</span></button>
</div>
<div class="section">
<label>Signature preview:</label>
diff --git a/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/refactoring/ui/refactoring.css b/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/refactoring/ui/refactoring.css
index c1c7f0fcf2dd..c725eb85e60c 100644
--- a/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/refactoring/ui/refactoring.css
+++ b/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/refactoring/ui/refactoring.css
@@ -115,19 +115,22 @@ label {
}
.action-button {
border: none;
- border-radius: 4px;
- padding: 2px;
- margin: 3px 0px;
+ padding: 4px 10px 4px 10px;
+ margin: 2px;
color: var(--vscode-input-foreground);
- background-color: transparent;
+ background-color: var(--vscode-list-hoverBackground);
}
+
.action-button:hover {
- background-color: var(--vscode-list-inactiveSelectionBackground);
+ color: var(--vscode-button-foreground);
+ background-color: var(--vscode-button-hoverBackground);
}
+
.action-button:focus, .action-button:hover:focus {
color: var(--vscode-button-foreground);
background-color: var(--vscode-button-hoverBackground);
- outline: none;
+ outline: 1px solid var(--vscode-button-hoverBackground);
+ outline-offset: 2px;
}
.checkbox-label {
align-self: center;