Skip to content

tlshd: fix a regression for certificate verification #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

tlshd: fix a regression for certificate verification #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/tlshd/handshake.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ void tlshd_start_tls_handshake(gnutls_session_t session,
} while (ret < 0 && !gnutls_error_is_fatal(ret));
tlshd_set_nagle(session, saved);
if (ret < 0) {
/* Any errors here should default to blocking access: */
parms->session_status = EACCES;
switch (ret) {
case GNUTLS_E_CERTIFICATE_VERIFICATION_ERROR:
tlshd_log_cert_verification_error(session);
Expand All @@ -100,7 +102,6 @@ void tlshd_start_tls_handshake(gnutls_session_t session,
break;
default:
tlshd_log_notice("tlshd_start_tls_handshake unhandled error %d, returning EACCES\n", ret);
parms->session_status = EACCES;
}
return;
}
Expand Down