Revert "tlshd: Do not return remote peer IDs for x.509 handshakes" #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d507771, which seems to break mTLS. The symptoms for NFS are that a mount seems to succeed but then all operations on the client return EPERM. Use g_array_append_val() to store the peer IDs, as is done in in the PSK callback functions. Signed-off-by: Ben Hutchings <[email protected]>
|
Manually pushed to ktls-utils-1.2-fixes. An official 1.2 minor release that includes this PR is forthcoming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d507771, which seems to break mTLS. The symptoms for NFS are that a mount seems to succeed but then all operations on the client return
EPERM.Use
g_array_append_val()to store the peer IDs, as is done in in the PSK callback functions.