tlshd: Return a non-zero peerid #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NFSD depends on seeing a non-zero peerid to know when the session has been authenticated (mTLS). Currently NFSD does not read or parse the remote peer's certificate. If tlshd fails to link the certificate onto the USER_SPEC keyring, it still needs to return a peerid that is non-zero to show that the remote peer presented a trusted certificate. Hack city. But this "fix" is compatible with older kernels and ktls-utils releases. A more complete fix is forthcoming. Signed-off-by: Chuck Lever <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NFSD depends on seeing a non-zero peerid to know when the session has been authenticated (mTLS). Currently NFSD does not read or parse the remote peer's certificate.
If tlshd fails to link the certificate onto the USER_SPEC keyring, it still needs to return a peerid that is non-zero to show that the remote peer presented a trusted certificate.
Hack city. But this "fix" is compatible with older kernels and ktls-utils releases. A more complete fix is forthcoming.