tlshd: use gnutls_handshake_write() for Session Ticket processing in quic #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quic When retrieving session data, GnuTLS must not run a full gnutls_handshake() while processing a TLS Session Ticket message. The existing code called quic_handshake_process(), which internally invoked gnutls_handshake() and caused failures with the latest GnuTLS versions. Fix this by calling gnutls_handshake_write() directly in quic_session_get_data() when handling the Session Ticket message. Signed-off-by: Xin Long <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When retrieving session data, GnuTLS must not run a full gnutls_handshake() while processing a TLS Session Ticket message. The existing code called quic_handshake_process(), which internally invoked gnutls_handshake() and caused failures with the latest GnuTLS versions.
Fix this by calling gnutls_handshake_write() directly in quic_session_get_data() when handling the Session Ticket message.