tlshd: always link .nvme default keyring into the session #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A common use case for tlshd is to authenticate TLS sessions for the nvme subsystem. Currently, the user has to explicitly list a keyring (even the defautl one) in the configuration file so that tlshd running as daemon (started via systemd) to find any key. Thus always link the default .nvme keyring into the current session, which makes the daemon work out of the box for default configurations. Signed-off-by: Daniel Wagner <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
hreinecke
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common use case for tlshd is to authenticate TLS sessions for the nvme subsystem. Currently, the user has to explicitly list a keyring (even the defautl one) in the configuration file so that tlshd running as daemon (started via systemd) to find any key.
Thus always link the default .nvme keyring into the current session, which makes the daemon work out of the box for default configurations.
@hreinecke