generated from oracle/template-repo
-
Notifications
You must be signed in to change notification settings - Fork 17
Add multimodal image embedding support to OCIGenAIEmbeddings #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fede-kamel
wants to merge
3
commits into
oracle:main
Choose a base branch
from
fede-kamel:add-multimodal-image-embedding
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,236
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54cd3c0 to
b283161
Compare
Contributor
Author
Integration Testing UpdateRan full integration tests for the image embedding feature — all 43 tests pass. Models testedText embedding models (5):
Image embedding models (2):
Test coverage
Notes
|
Add to_data_uri() as core primitive for converting file paths, bytes, or data URIs to data URI strings. Refactor load_image/encode_image to use it. Move IMAGE_EMBEDDING_MODELS registry here alongside VISION_MODELS.
New embed_image/embed_images methods via ImageEmbeddingMixin in embeddings/image.py. Supports file paths, raw bytes, and data URIs. Add input_type and output_dimensions fields. Unit tests included.
- Rename embed_images() to embed_image_batch() for clarity - Add image embedding examples to README.md (section 3b) - Update all tests to use new method name
b283161 to
4be66e6
Compare
Contributor
Author
|
@paxiaatucsdedu Addressed your review feedback:
Changes rebased onto latest main. |
Contributor
Author
|
Integration tests passed (43/43) Tested with real OCI GenAI API in Frankfurt region: Image Embedding Models (multimodal):
Text Embedding Models:
Confirmed working:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends OCIGenAIEmbeddings with image embedding support. Multimodal models like cohere.embed-v4.0 embed text and images into the same vector space, enabling cross-modal retrieval (search images with text, find text from images).
Builds on the vision utilities from #99 and #104 (data URI convention, vision.py module).
What changed:
Quick example:
Tested against all 6 available OCI embedding models (embed-v4.0, embed-english-v3.0, embed-english-light-v3.0, embed-multilingual-v3.0, embed-multilingual-light-v3.0, embed-multilingual-image-v3.0). 38 unit tests + 43 integration tests, ruff clean.